lib/compiler/implementation/js_backend/namer.dart - Issue 10996039: Bring type variables into static scope, but produce compile-time error when they are used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/js_backend/namer.dart

Issue 10996039: Bring type variables into static scope, but produce compile-time error when they are used. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Produce warning and dynamic type error instead of compile-time error. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/elements/elements.dart ('k') | lib/compiler/implementation/resolver.dart » ('j') | lib/compiler/implementation/resolver.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/js_backend/namer.dart

diff --git a/lib/compiler/implementation/js_backend/namer.dart b/lib/compiler/implementation/js_backend/namer.dart

index a5ec408306d4d29ef453bb18f8a2d632f737bd28..dd8ab2e9a8808f6145583cecb7aee0be57adea28 100644

--- a/lib/compiler/implementation/js_backend/namer.dart

+++ b/lib/compiler/implementation/js_backend/namer.dart

@@ -270,7 +270,8 @@ class Namer {

kind === ElementKind.GETTER ||

kind === ElementKind.SETTER ||

kind === ElementKind.TYPEDEF ||

- kind === ElementKind.LIBRARY) {

+ kind === ElementKind.LIBRARY ||

+ kind === ElementKind.MALFORMED_TYPE) {

String result = getFreshGlobalName(guess);

globals[element] = result;

return result;