Bring type variables into static scope, but produce compile-time error when they are used.

lib/compiler/implementation/elements/elements.dart

Index: lib/compiler/implementation/elements/elements.dart
diff --git a/lib/compiler/implementation/elements/elements.dart b/lib/compiler/implementation/elements/elements.dart
index 3775bc740d446d42d288da93064db6a366e48a8f..70560c1a69d6a93bb95bb31b0c8dacae8f3aa99d 100644
--- a/lib/compiler/implementation/elements/elements.dart
+++ b/lib/compiler/implementation/elements/elements.dart
@@ -342,6 +342,10 @@ class Element implements Hashable, Spannable {
 
   FunctionElement asFunctionElement() => null;
 
+  bool inStaticContext() {
+    return modifiers !== null && modifiers.isStatic();
+  }
+
   Element cloneTo(Element enclosing, DiagnosticListener listener) {
     listener.cancel("Unimplemented cloneTo", element: this);
   }
@@ -856,13 +860,12 @@ class VariableListElement extends Element {
     return isMember() && !modifiers.isStatic();
   }
 
+  bool inStaticContext() {
+    return super.inStaticContext() || enclosingElement.inStaticContext();
+  }
+
   Scope buildScope() {
-    Scope result = new VariableScope(enclosingElement.buildScope(), this);
-    if (enclosingElement.isClass()) {
-      ClassScope clsScope = result.parent;
-      clsScope.inStaticContext = !isInstanceMember();
-    }
-    return result;
+    return new VariableScope(enclosingElement.buildScope(), this);
   }
 }
 
@@ -1125,13 +1128,7 @@ class FunctionElement extends Element {
   }
 
   Scope buildScope() {

[Johnni Winther, 2012/10/02 09:07:30]

Remove this method. MethodScope is mutable and should only be created in the
ResolverVisitor. 

[aam-me, 2012/10/02 12:50:39]

Johnni,

  removing this method causes "Internal error: Cannot add an element in a class
scope" as in below. Did I miss something? Please, advise. Thanks!

===
C:\dart_bleeding\dart-repo.9\dart>tools\test.py -mrelease -cdart2js -rd8
co19/Language/03_Overview/1_Scoping_A02_t05
Test configuration: dart2js_d8_release_ia32
[00:00 |  --% | +    0 | -    0]
FAILED: dart2js-d8 release_ia32 co19/Language/03_Overview/1_Scoping_A02_t05
Expected: pass
Actual: crash
Unexpected compile-time error.

stdout:
lib/core/expect.dart:70:15: Error: The compiler crashed when compiling this
element.
  static void fail(String msg) {
              ^^^^
The compiler is broken.

...

Internal error: Cannot add an element in a class scope
#0      ClassScope.add
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/resolver.dart:2854:5)
#1      ResolverVisitor.defineElement
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/resolver.dart:1118:35)
#2      ResolverVisitor.setupFunction.<anonymous closure>
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/resolver.dart:1167:22)
#3      FunctionSignature.forEachRequiredParameter
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/elements/elements.dart:963:15)
#4      FunctionSignature.forEachParameter
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/elements/elements.dart:988:29)
#5      ResolverVisitor.setupFunction
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/resolver.dart:1154:40)
#6      ResolverTask.resolveMethodElement.<anonymous closure>
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/resolver.dart:148:28)
#7      Compiler.withCurrentElement
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/compiler.dart:135:15)
#8      Compiler.withCurrentElement
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/compiler.dart:148:7)
#9      ResolverTask.resolveMethodElement
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/resolver.dart:131:39)
#10     ResolverTask.resolve.<anonymous closure>
(file:///C:/dart_bleeding/dart-repo.9/dart/lib/compiler/implementation/resolver.dart:73:36)
...
===

[Johnni Winther, 2012/10/03 10:40:33]

OK. Just leave it there. I'll try to remove it in another CL.

-    Scope result =
-        new MethodScope(enclosingElement.buildScope(), this);
-    if (enclosingElement.isClass()) {
-      Scope clsScope = result.parent;
-      clsScope.inStaticContext = !isInstanceMember() && !isConstructor();
-    }
-    return result;
+    return new MethodScope(enclosingElement.buildScope(), this);
   }
 }