Chromium Code Reviews
Help | Chromium Project | Sign in
(1069)

Issue 10993066: Add oem mount point to cros_mount_provider. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by tbarzic
Modified:
1 year, 6 months ago
Reviewers:
kinuko, zel
CC:
chromium-reviews_chromium.org, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, tzik+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add oem mount point to cros_mount_provider.

The new mount point will be accessible will be accessible by file manager
extension, but it won't be shown in the UI.
The mount point will contain Timescapes-ChromeOS video which will be playable in
the media player.

BUG=152216
TEST=manual (tried playing video on oem mount point using media player)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159856

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : forgot one file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -14 lines) Lint Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 2 3 4 5 6 chunks +64 lines, -8 lines 0 comments 0 errors Download
M chrome/test/data/extensions/api_test/filebrowser_component/remote.js View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments ? errors Download
A + chrome/test/data/extensions/api_test/filebrowser_component/restricted.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments ? errors Download
A chrome/test/data/extensions/api_test/filebrowser_component/restricted.js View 1 2 3 4 5 6 7 1 chunk +260 lines, -0 lines 0 comments ? errors Download
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 2 3 4 5 8 chunks +35 lines, -4 lines 2 comments ? errors Download
M webkit/fileapi/file_system_context.cc View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
M webkit/fileapi/file_system_mount_point_provider.h View 1 2 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M webkit/fileapi/file_system_types.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
M webkit/fileapi/local_file_system_operation.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 13
tbarzic
Please, take a look. Talked with Min Li and she confirmed with cmasone that it ...
1 year, 6 months ago #1
zel
http://codereview.chromium.org/10993066/diff/1/chrome/browser/chromeos/extensions/file_handler_util.cc File chrome/browser/chromeos/extensions/file_handler_util.cc (right): http://codereview.chromium.org/10993066/diff/1/chrome/browser/chromeos/extensions/file_handler_util.cc#newcode724 chrome/browser/chromeos/extensions/file_handler_util.cc:724: if (url.filesystem_id() == kOemMountPointID) { let's create a more ...
1 year, 6 months ago #2
tbarzic
did you mean something like this?
1 year, 6 months ago #3
zel
'restricted' here is actually enforced 'read-only', you should put that somewhere in comments. also, this ...
1 year, 6 months ago #4
tbarzic
On 2012/09/27 22:35:03, zel wrote: > 'restricted' here is actually enforced 'read-only', you should put ...
1 year, 6 months ago #5
tbarzic
On 2012/09/27 23:36:49, tbarzic wrote: > On 2012/09/27 22:35:03, zel wrote: > > 'restricted' here ...
1 year, 6 months ago #6
zel
lgtm
1 year, 6 months ago #7
kinuko
http://codereview.chromium.org/10993066/diff/27001/webkit/chromeos/fileapi/cros_mount_point_provider.cc File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right): http://codereview.chromium.org/10993066/diff/27001/webkit/chromeos/fileapi/cros_mount_point_provider.cc#newcode194 webkit/chromeos/fileapi/cros_mount_point_provider.cc:194: file_access_permissions_->GrantAccessPermission( Do we also need to avoid calling this ...
1 year, 6 months ago #8
kinuko
On 2012/10/03 02:38:04, kinuko wrote: > http://codereview.chromium.org/10993066/diff/27001/webkit/chromeos/fileapi/cros_mount_point_provider.cc > File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right): > > http://codereview.chromium.org/10993066/diff/27001/webkit/chromeos/fileapi/cros_mount_point_provider.cc#newcode194 > ...
1 year, 6 months ago #9
tbarzic
http://codereview.chromium.org/10993066/diff/27001/webkit/chromeos/fileapi/cros_mount_point_provider.cc File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right): http://codereview.chromium.org/10993066/diff/27001/webkit/chromeos/fileapi/cros_mount_point_provider.cc#newcode194 webkit/chromeos/fileapi/cros_mount_point_provider.cc:194: file_access_permissions_->GrantAccessPermission( On 2012/10/03 02:38:04, kinuko wrote: > Do we ...
1 year, 6 months ago #10
kinuko
On 2012/10/03 02:47:32, tbarzic wrote: > http://codereview.chromium.org/10993066/diff/27001/webkit/chromeos/fileapi/cros_mount_point_provider.cc > File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right): > > http://codereview.chromium.org/10993066/diff/27001/webkit/chromeos/fileapi/cros_mount_point_provider.cc#newcode194 > ...
1 year, 6 months ago #11
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/10993066/27001
1 year, 6 months ago #12
I haz the power (commit-bot)
1 year, 6 months ago #13
Change committed as 159856
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6