Issue 10993018: Re-land r158555: "[Android] Exclude unsupported URLs from chrome://chrome-urls."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10993018: Re-land r158555: "[Android] Exclude unsupported URLs from chrome://chrome-urls." (Closed)

Created:
8 years, 2 months ago by newt (away)

Modified:
8 years, 2 months ago

Reviewers:
Nico

CC:
chromium-reviews, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Re-land r158555: "[Android] Exclude unsupported URLs from chrome://chrome-urls." Original code review: https://chromiumcodereview.appspot.com/10980008/ Reverted by: https://codereview.chromium.org/10993005/ This CL fixes builtin_provider_unittest.cc which was broken by the previous CL. BUG=136996 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158753

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -46 lines)			Patch
	M	chrome/browser/autocomplete/builtin_provider_unittest.cc	View		3 chunks	+33 lines, -32 lines	0 comments	Download
	M	chrome/browser/browser_about_handler.cc	View		2 chunks	+23 lines, -14 lines	0 comments	Download

Total messages: 4 (0 generated)

newt (away)

This is a re-land of my previous CL, this time with the test fixed on ...

8 years, 2 months ago (2012-09-25 21:38:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10993018/1

8 years, 2 months ago (2012-09-26 02:43:38 UTC) #3

Change committed as 158753