Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Issue 10993015: drive: Remove --enable-drive-v2-api from about:flags (Closed)

Created:
8 years, 2 months ago by satorux1
Modified:
8 years, 2 months ago
Reviewers:
Lei Zhang, achuithb, kochi
CC:
chromium-reviews
Visibility:
Public.

Description

drive: Remove --enable-drive-v2-api from about:flags The feature under the flag is not yet ready to be exposed to users. Besides, the flag was a source of mysterious crash bugs. BUG=152230, 151957, 149009, 151963 TEST="Enable Drive V2 API" is gone from about:flags Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158789

Patch Set 1 #

Patch Set 2 : address comments #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
satorux1
8 years, 2 months ago (2012-09-25 20:54:47 UTC) #1
achuithb
lgtm
8 years, 2 months ago (2012-09-25 21:40:29 UTC) #2
achuithb
On 2012/09/25 21:40:29, achuith.bhandarkar wrote: > lgtm Actually, can you also remove kEnableDriveV2Api from chrome_switches.{h|cc}?
8 years, 2 months ago (2012-09-25 21:55:47 UTC) #3
satorux1
good idea. removed from chrome_switches.h/cc
8 years, 2 months ago (2012-09-25 22:03:22 UTC) #4
achuithb
lgtm
8 years, 2 months ago (2012-09-25 22:10:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/10993015/1003
8 years, 2 months ago (2012-09-25 22:12:19 UTC) #6
commit-bot: I haz the power
Presubmit check for 10993015-1003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-09-25 22:12:23 UTC) #7
satorux1
Lei, could you take a look?
8 years, 2 months ago (2012-09-25 22:15:42 UTC) #8
Lei Zhang
lgtm
8 years, 2 months ago (2012-09-25 22:22:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/10993015/1003
8 years, 2 months ago (2012-09-25 22:41:55 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-25 23:06:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/10993015/7005
8 years, 2 months ago (2012-09-25 23:18:05 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-25 23:39:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/10993015/14003
8 years, 2 months ago (2012-09-26 05:43:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/10993015/14003
8 years, 2 months ago (2012-09-26 10:14:41 UTC) #15
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 12:04:43 UTC) #16
Change committed as 158789

Powered by Google App Engine
This is Rietveld 408576698