Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issue 10991068: Have content_browser depend on printing only if not on iOS. (Closed)

Created:
8 years, 2 months ago by blundell
Modified:
8 years, 2 months ago
Reviewers:
raymes, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Have content_browser depend on printing only if not on iOS. iOS does not build printing.gyp:printing, so the iOS build was broken by https://chromiumcodereview.appspot.com/10826072, which added that target as an unconditional dependency of content_browser. BUG=None TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/content_browser.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
blundell
Tiny followup to https://chromiumcodereview.appspot.com/10826072.
8 years, 2 months ago (2012-09-28 09:35:35 UTC) #1
rohitrao (ping after 24h)
LGTM I believe that jam has indicated in the past that TBR=jam is acceptable for ...
8 years, 2 months ago (2012-09-28 12:39:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/10991068/1
8 years, 2 months ago (2012-09-28 12:41:18 UTC) #3
blundell
8 years, 2 months ago (2012-09-28 12:48:03 UTC) #4
raymes
lgtm thanks. Are there iOS bots?
8 years, 2 months ago (2012-09-28 14:37:05 UTC) #5
blundell
On 2012/09/28 14:37:05, raymes wrote: > lgtm thanks. Are there iOS bots? They are fyi ...
8 years, 2 months ago (2012-09-28 14:43:27 UTC) #6
raymes
Good to know. Thanks! On Fri, Sep 28, 2012 at 7:43 AM, <blundell@chromium.org> wrote: > ...
8 years, 2 months ago (2012-09-28 14:51:12 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 2 months ago (2012-09-28 14:55:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/10991068/1
8 years, 2 months ago (2012-09-28 14:57:36 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-09-28 14:57:45 UTC) #10
Change committed as 159260

Powered by Google App Engine
This is Rietveld 408576698