Use existing logic in list.js to correctly set aria-activedescandant for the file list.

Use existing logic in list.js to correctly set aria-activedescandant for the file list.

This means that each file row will be spoken as it is selected.

BUG=151471
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158786

[dmazzoni, 2012-09-26 06:38:17]

Thanks! I'm glad you were able to leverage the existing ARIA accessibility in
cr.ui.list.

lgtm for accessibility. Adding dgozman for file_manager.js and dbeam for cr/ui

[Dan Beam, 2012-09-26 06:41:53]

+yoshiki@, I can stamp after (I don't know this code very well)

[yoshiki, 2012-09-26 07:06:17]

http://codereview.chromium.org/10991033/diff/2001/chrome/browser/resources/sh...
File chrome/browser/resources/shared/js/cr/ui/table/table_list.js (right):

http://codereview.chromium.org/10991033/diff/2001/chrome/browser/resources/sh...
chrome/browser/resources/shared/js/cr/ui/table/table_list.js:73:
renderFunction_: function(dataItem) {
I think using "this" is not good idea, because renderFunction is designed not to
care "this". If you would want to use "this", you should edit more other codes.

http://codereview.chromium.org/10991033/diff/2001/chrome/browser/resources/sh...
chrome/browser/resources/shared/js/cr/ui/table/table_list.js:76: var listItem =
List.prototype.createItem.call(this, '');
Instead of using "this", can you use "table.list"?

[aboxhall, 2012-09-26 07:20:40]

http://codereview.chromium.org/10991033/diff/2001/chrome/browser/resources/sh...
File chrome/browser/resources/shared/js/cr/ui/table/table_list.js (right):

http://codereview.chromium.org/10991033/diff/2001/chrome/browser/resources/sh...
chrome/browser/resources/shared/js/cr/ui/table/table_list.js:73:
renderFunction_: function(dataItem) {
On 2012/09/26 07:06:17, yoshiki wrote:
> I think using "this" is not good idea, because renderFunction is designed not
to
> care "this". If you would want to use "this", you should edit more other
codes.

Ok.

http://codereview.chromium.org/10991033/diff/2001/chrome/browser/resources/sh...
chrome/browser/resources/shared/js/cr/ui/table/table_list.js:76: var listItem =
List.prototype.createItem.call(this, '');
On 2012/09/26 07:06:17, yoshiki wrote:
> Instead of using "this", can you use "table.list"?

That works well, thanks!

[yoshiki, 2012-09-26 07:30:29]

LGTM

[commit-bot: I haz the power, 2012-09-26 08:02:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/10991033/7002

[commit-bot: I haz the power, 2012-09-26 08:02:45]

Presubmit check for 10991033-7002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/resources

[Dan Beam, 2012-09-26 08:03:00]

lgtm

[commit-bot: I haz the power, 2012-09-26 08:03:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/10991033/7002

[commit-bot: I haz the power, 2012-09-26 11:34:00]

Change committed as 158786