Issue 10991012: Fix 2346: Generic KeyedStoreIC doesn't change length and element_kind atomically

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10991012: Fix 2346: Generic KeyedStoreIC doesn't change length and element_kind atomically (Closed)

Created:
8 years, 2 months ago by danno

Modified:
8 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix 2346: Generic KeyedStoreIC doesn't change length and element_kind atomically R=erik.corry@gmail.com BUG=v8:2346 Committed: https://code.google.com/p/v8/source/detail?r=12603

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review feedback #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -101 lines)			Patch
	M	src/ia32/ic-ia32.cc	View	1	5 chunks	+128 lines, -101 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

8 years, 2 months ago (2012-09-25 09:26:26 UTC) #2

LGTM, hold the test :-)

https://chromiumcodereview.appspot.com/10991012/diff/1/src/ia32/ic-ia32.cc
File src/ia32/ic-ia32.cc (right):

https://chromiumcodereview.appspot.com/10991012/diff/1/src/ia32/ic-ia32.cc#ne...
src/ia32/ic-ia32.cc:750: static void
KeyedStoreGeneratGenericHelper(MacroAssembler* masm,
Ken Thompson was once asked what he would do differently if he were redesigning
the UNIX system. His reply: "I'd spell creat with an e."

https://chromiumcodereview.appspot.com/10991012/diff/1/src/ia32/ic-ia32.cc#ne...
src/ia32/ic-ia32.cc:817: // Add 1 to receiver->length, and go to common element
store code for
Comment out of date.

https://chromiumcodereview.appspot.com/10991012/diff/1/src/ia32/ic-ia32.cc#ne...
src/ia32/ic-ia32.cc:869: 
Missing blank line.

Expand Messages | Collapse Messages