Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 10991007: [OSX] Forward Flapper GetLocalTimeZoneOffset() to browser on OSX. (Closed)

Created:
8 years, 3 months ago by Scott Hess - ex-Googler
Modified:
8 years, 2 months ago
Reviewers:
sail, viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

[OSX] Forward Flapper GetLocalTimeZoneOffset() to browser on OSX. The local version is broken by the sandbox. AFAICT the sandbox warmup should allow this to work, but does not. BUG=149006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158514

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ppapi/proxy/ppb_flash_proxy.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
Scott Hess - ex-Googler
Not entirely sure if this is correct, but AFAICT the sandbox initialization order is correct ...
8 years, 3 months ago (2012-09-24 23:17:26 UTC) #1
sail
LGTM!
8 years, 3 months ago (2012-09-24 23:22:20 UTC) #2
Scott Hess - ex-Googler
On 2012/09/24 23:22:20, sail wrote: > LGTM! Thanks! Holding out for vtl@ review for OWNERS!
8 years, 3 months ago (2012-09-24 23:32:12 UTC) #3
viettrungluu
LGTM, assuming it works. https://chromiumcodereview.appspot.com/10991007/diff/1/ppapi/proxy/ppb_flash_proxy.cc File ppapi/proxy/ppb_flash_proxy.cc (right): https://chromiumcodereview.appspot.com/10991007/diff/1/ppapi/proxy/ppb_flash_proxy.cc#newcode252 ppapi/proxy/ppb_flash_proxy.cc:252: dispatcher()->Send(new PpapiHostMsg_PPBFlash_GetLocalTimeZoneOffset( I assume this ...
8 years, 3 months ago (2012-09-25 00:19:35 UTC) #4
Scott Hess - ex-Googler
On 2012/09/25 00:19:35, viettrungluu wrote: > LGTM, assuming it works. <eyeroll> > https://chromiumcodereview.appspot.com/10991007/diff/1/ppapi/proxy/ppb_flash_proxy.cc > File ...
8 years, 2 months ago (2012-09-25 01:16:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10991007/1
8 years, 2 months ago (2012-09-25 01:16:16 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 03:20:17 UTC) #7
Change committed as 158514

Powered by Google App Engine
This is Rietveld 408576698