content/browser/notifications/platform_notification_context_impl.h - Issue 1099093003: Push API: Forced notifications should use Notifications database

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/platform_notification_context_impl.h

Issue 1099093003: Push API: Forced notifications should use Notifications database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Peter's review nits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | content/public/browser/platform_notification_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/platform_notification_context_impl.h

diff --git a/content/browser/notifications/platform_notification_context_impl.h b/content/browser/notifications/platform_notification_context_impl.h

index e208324774b82d65da0be59cc4297ef82859a774..c6b370d4b4b70df50ca7151c5c7e94a203fa0e99 100644

--- a/content/browser/notifications/platform_notification_context_impl.h

+++ b/content/browser/notifications/platform_notification_context_impl.h

@@ -34,9 +34,7 @@ class ServiceWorkerContextWrapper;

// otherwise specified.

class CONTENT_EXPORT PlatformNotificationContextImpl

: NON_EXPORTED_BASE(public PlatformNotificationContext),

- NON_EXPORTED_BASE(public ServiceWorkerContextObserver),

- public base::RefCountedThreadSafe<PlatformNotificationContextImpl,

- BrowserThread::DeleteOnUIThread> {

+ NON_EXPORTED_BASE(public ServiceWorkerContextObserver) {

public:

// Constructs a new platform notification context. If |path| is non-empty, the

// database will be initialized in the "Platform Notifications" subdirectory

@@ -73,10 +71,6 @@ class CONTENT_EXPORT PlatformNotificationContextImpl

void OnStorageWiped() override;

private:

- friend class base::DeleteHelper<PlatformNotificationContextImpl>;

- friend class base::RefCountedThreadSafe<PlatformNotificationContextImpl,

- BrowserThread::DeleteOnUIThread>;

- friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>;

friend class PlatformNotificationContextTest;

~PlatformNotificationContextImpl() override;