Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10990116: [cc] Color evicted vs. invalidated checkerboard tiles differently (Closed)

Created:
8 years, 2 months ago by enne (OOO)
Modified:
8 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Color evicted vs. invalidated checkerboard tiles differently If --show-debug-layer-borders are on, tint checkerboards differently. * Light red = texture backing for tile was evicted or never painted * Light blue = we have a texture backing, but it's been invalidated Previously reverted: https://codereview.chromium.org/10962042/ BUG=150610 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -79 lines) Patch
M cc/CCCheckerboardDrawQuad.h View 2 chunks +7 lines, -2 lines 0 comments Download
M cc/CCCheckerboardDrawQuad.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/CCDrawQuadTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M cc/CCRenderPassTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRendererGL.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/CCTiledLayerImpl.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/CCTiledLayerImpl.cpp View 4 chunks +33 lines, -4 lines 0 comments Download
M cc/ShaderChromium.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/ShaderChromium.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M cc/TiledLayerChromium.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M cc/TiledLayerChromiumTest.cpp View 24 chunks +62 lines, -62 lines 0 comments Download
M cc/test/CCTiledLayerTestCommon.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
I thought I had run cc_unittests, but apparently not. Also, since the CQ doesn't run ...
8 years, 2 months ago (2012-09-28 19:37:46 UTC) #1
jamesr
lgtm I think the CQ should run cc_unittests now thanks to http://code.google.com/p/chromium/issues/detail?id=146369#c4
8 years, 2 months ago (2012-09-28 19:40:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/10990116/1
8 years, 2 months ago (2012-09-28 19:41:44 UTC) #3
enne (OOO)
On 2012/09/28 19:40:33, jamesr wrote: > lgtm > > I think the CQ should run ...
8 years, 2 months ago (2012-09-28 19:41:48 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-09-28 22:00:11 UTC) #5
Change committed as 159346

Powered by Google App Engine
This is Rietveld 408576698