Removing the "learn more" link for session restore.

Removing the "learn more" link for session restore.

TBR=sky@chromium.org
BUG=133263
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158807

[marja, 2012-09-26 12:34:17]

Evan, since you're on the same time zone, yay, could you review this?

Btw, it seems that it's not enough to just apply this patch and rebuild; some
components are not properly rebuilt, and the link is still there (though it has
no target). I'll file a bug (unless there is one already...)

[Evan Stade, 2012-09-26 13:42:25]

lgtm

I vaguely remember that flackr might have been trying to fix that resource file
rebuilding bug?

[commit-bot: I haz the power, 2012-09-26 13:48:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10990052/1

[commit-bot: I haz the power, 2012-09-26 13:48:28]

Failed to apply patch for
chrome/browser/ui/webui/options/browser_options_handler.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/webui/options/browser_options_handler.cc
Hunk #1 FAILED at 392.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/webui/options/browser_options_handler.cc.rej

[commit-bot: I haz the power, 2012-09-26 13:55:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10990052/5001

[commit-bot: I haz the power, 2012-09-26 13:55:15]

Presubmit check for 10990052-5001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[flackr, 2012-09-26 13:56:30]

On 2012/09/26 13:42:25, Evan Stade wrote:
> lgtm
> 
> I vaguely remember that flackr might have been trying to fix that resource
file
> rebuilding bug?

There was a grit bug a while back, http://crbug.com/131483 but that was
resolved. As mentioned in that bug, comment #1 you can try running python
tools/grit/grit_info.py --inputs foo.grd where foo.grd is the grd file including
startup_section.html, i.e chrome/browser/resources/options_resources.grd to
verify that it's detecting all of the input files correctly. Perhaps there is a
new bug related to detecting flattened resources?

[commit-bot: I haz the power, 2012-09-26 13:57:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10990052/5001

[marja, 2012-09-26 13:58:10]

... TBRing this, since the non-OWNERS-reviewed part is trivial.

[marja, 2012-09-26 14:20:50]

On 2012/09/26 13:56:30, flackr wrote:
> On 2012/09/26 13:42:25, Evan Stade wrote:
> > lgtm
> > 
> > I vaguely remember that flackr might have been trying to fix that resource
> file
> > rebuilding bug?
> 
> There was a grit bug a while back, http://crbug.com/131483 but that was
> resolved. As mentioned in that bug, comment #1 you can try running python
> tools/grit/grit_info.py --inputs foo.grd where foo.grd is the grd file
including
> startup_section.html, i.e chrome/browser/resources/options_resources.grd to
> verify that it's detecting all of the input files correctly. Perhaps there is
a
> new bug related to detecting flattened resources?

When I run tools/grit/grit_info.py --inputs
chrome/browser/resources/options_resources.grd , the output indeed doesn't
include startup_options.html.

It seems that nothing which is only included via browser_options.html is
detected (startup_section.html and sync_section.html), whereas resources
included directly by options.html are detected.

[flackr, 2012-09-26 14:53:38]

On 2012/09/26 14:20:50, marja wrote:
> On 2012/09/26 13:56:30, flackr wrote:
> > On 2012/09/26 13:42:25, Evan Stade wrote:
> > > lgtm
> > > 
> > > I vaguely remember that flackr might have been trying to fix that resource
> > file
> > > rebuilding bug?
> > 
> > There was a grit bug a while back, http://crbug.com/131483 but that was
> > resolved. As mentioned in that bug, comment #1 you can try running python
> > tools/grit/grit_info.py --inputs foo.grd where foo.grd is the grd file
> including
> > startup_section.html, i.e chrome/browser/resources/options_resources.grd to
> > verify that it's detecting all of the input files correctly. Perhaps there
is
> a
> > new bug related to detecting flattened resources?
> 
> When I run tools/grit/grit_info.py --inputs
> chrome/browser/resources/options_resources.grd , the output indeed doesn't
> include startup_options.html.
> 
> It seems that nothing which is only included via browser_options.html is
> detected (startup_section.html and sync_section.html), whereas resources
> included directly by options.html are detected.

I wrote up a description of the issue in a new bug http://crbug.com/152425/

[commit-bot: I haz the power, 2012-09-26 16:18:11]

Change committed as 158807