Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 10990026: Disable history menu in incognito or guest mode (Closed)

Created:
8 years, 2 months ago by simonhong_
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@new
Visibility:
Public.

Description

Disable history menu in incognito or guest mode BUG=127627 TEST=manual test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158808

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use Profile::IsGuestSession() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/browser_command_controller.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
simonhong_
Dear Scott, Please review this patch. Thank you.
8 years, 2 months ago (2012-09-25 14:03:26 UTC) #1
sky
https://codereview.chromium.org/10990026/diff/1/chrome/browser/ui/browser_command_controller.cc File chrome/browser/ui/browser_command_controller.cc (right): https://codereview.chromium.org/10990026/diff/1/chrome/browser/ui/browser_command_controller.cc#newcode838 chrome/browser/ui/browser_command_controller.cc:838: !ProfileManager::GetDefaultProfileOrOffTheRecord()->IsOffTheRecord()); I think you want Profile::IsGuestSession().
8 years, 2 months ago (2012-09-25 16:05:27 UTC) #2
simonhong_
Does Disabling history menu make sense only in ChromeOS? On 2012/09/25 16:05:27, sky wrote: > ...
8 years, 2 months ago (2012-09-26 10:28:26 UTC) #3
simonhong_
https://codereview.chromium.org/10990026/diff/1/chrome/browser/ui/browser_command_controller.cc File chrome/browser/ui/browser_command_controller.cc (right): https://codereview.chromium.org/10990026/diff/1/chrome/browser/ui/browser_command_controller.cc#newcode838 chrome/browser/ui/browser_command_controller.cc:838: !ProfileManager::GetDefaultProfileOrOffTheRecord()->IsOffTheRecord()); On 2012/09/25 16:05:27, sky wrote: > I think ...
8 years, 2 months ago (2012-09-26 13:26:25 UTC) #4
sky
LGTM - yes, only makes sense for chromeos.
8 years, 2 months ago (2012-09-26 13:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10990026/1003
8 years, 2 months ago (2012-09-26 13:48:47 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 16:21:25 UTC) #7
Change committed as 158808

Powered by Google App Engine
This is Rietveld 408576698