Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10990021: Factory reset dialog string change. (Closed)

Created:
8 years, 2 months ago by glotov
Modified:
8 years, 2 months ago
Reviewers:
csilv, Nikita (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Factory reset dialog string change. BUG=122768 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158781

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/resources/options/factory_reset_overlay.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
glotov
Hi! 1-line change, please have a look.
8 years, 2 months ago (2012-09-25 10:06:34 UTC) #1
Nikita (slow)
http://codereview.chromium.org/10990021/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): http://codereview.chromium.org/10990021/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode387 chrome/browser/ui/webui/options/browser_options_handler.cc:387: IDS_OPTIONS_FACTORY_RESET_WARNING, It seems that you have 2 strings that ...
8 years, 2 months ago (2012-09-25 12:00:08 UTC) #2
glotov
http://codereview.chromium.org/10990021/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): http://codereview.chromium.org/10990021/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode387 chrome/browser/ui/webui/options/browser_options_handler.cc:387: IDS_OPTIONS_FACTORY_RESET_WARNING, On 2012/09/25 12:00:08, Nikita Kostylev wrote: > It ...
8 years, 2 months ago (2012-09-25 12:07:39 UTC) #3
Nikita (slow)
8 years, 2 months ago (2012-09-25 12:45:08 UTC) #4
Nikita (slow)
lgtm
8 years, 2 months ago (2012-09-25 12:45:14 UTC) #5
csilv
lgtm
8 years, 2 months ago (2012-09-25 16:58:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/10990021/2002
8 years, 2 months ago (2012-09-25 17:01:24 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 2 months ago (2012-09-25 20:03:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/10990021/2002
8 years, 2 months ago (2012-09-26 08:45:36 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 11:17:07 UTC) #10 
Change committed as 158781

Powered by Google App Engine
This is Rietveld 408576698