Issue 10990017: Fix OpaqueBrowserFrameView title painting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10990017: Fix OpaqueBrowserFrameView title painting. (Closed)

Created:
8 years, 2 months ago by msw

Modified:
8 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix OpaqueBrowserFrameView title painting. Add/use |window_title_| Label instead of Canvas::DrawStringInt. Nix PaintTitleBar; inline its comments. Simplify LayoutTitleBar (use Label's vertical centering, etc.) BUG=140670 TEST=App shortcut window titlebars always update appropriately; no window title/frame regressions. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159087

Patch Set 1 #

Patch Set 2 : Use a title Label instead of Canvas::DrawStringInt. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -46 lines)			Patch
	M	chrome/browser/ui/views/frame/opaque_browser_frame_view.h	View	1	4 chunks	+3 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/views/frame/opaque_browser_frame_view.cc	View	1	6 chunks	+33 lines, -41 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

msw

Hey Ben, please take a look; thanks! Note Patch Set 1's SchedulePaint() workaround works, but ...

8 years, 2 months ago (2012-09-25 03:16:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10990017/2001

8 years, 2 months ago (2012-09-27 17:15:38 UTC) #3

Change committed as 159087

Expand Messages | Collapse Messages