Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/ui/aura/tabs/dock_info_aurax11.cc

Issue 10990010: Fix tab dragging in unity2d (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blindly patches dock_info_aurax11.cc and simplifies query cache Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/tabs/dock_info_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/aura/tabs/dock_info_aurax11.cc
diff --git a/chrome/browser/ui/aura/tabs/dock_info_aurax11.cc b/chrome/browser/ui/aura/tabs/dock_info_aurax11.cc
index b32822cabb5311cf53a0876b4455ddc17abe2fc8..92478211528d48b5acdb5fe959fbfda055749b33 100644
--- a/chrome/browser/ui/aura/tabs/dock_info_aurax11.cc
+++ b/chrome/browser/ui/aura/tabs/dock_info_aurax11.cc
@@ -79,16 +79,11 @@ class TopMostFinder : public BaseWindowFinder {
return false;
}
- gfx::Rect rect;
- if (ui::GetWindowRect(window, &rect) && rect.Contains(screen_loc_)) {
- // At this point we haven't found our target window, so this window is
- // higher in the z-order than the target window. If this window contains
- // the point, then we can stop the search now because this window is
- // obscuring the target window at this point.
- return true;
- }
-
- return false;
+ // At this point we haven't found our target window, so this window is
+ // higher in the z-order than the target window. If this window contains
+ // the point, then we can stop the search now because this window is
+ // obscuring the target window at this point.
+ return ui::WindowContainsPoint(window, screen_loc_);
}
private:
@@ -147,8 +142,7 @@ class LocalProcessWindowFinder : public BaseWindowFinder {
if (!ui::IsWindowVisible(window))
return false;
- gfx::Rect rect;
- if (ui::GetWindowRect(window, &rect) && rect.Contains(screen_loc_)) {
+ if (ui::WindowContainsPoint(window, screen_loc_)) {
result_ = window;
return true;
}
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/tabs/dock_info_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698