sync/syncable/syncable_id.h - Issue 10989063: Changed DB to store node positions as Ordinals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/syncable_id.h

Issue 10989063: Changed DB to store node positions as Ordinals. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed memory leak error in unittest Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/syncable/syncable_id.h

diff --git a/sync/syncable/syncable_id.h b/sync/syncable/syncable_id.h

index 95157ab1213ce972eb4e5b623386f5a565b8562f..64fc7f695fe3ec3ec884e25fa6c54e8a1b2523f9 100644

--- a/sync/syncable/syncable_id.h

+++ b/sync/syncable/syncable_id.h

@@ -10,6 +10,7 @@

#include <sstream>

#include <string>

+#include "base/memory/scoped_ptr.h"

#include "base/hash_tables.h"

class MockConnectionManager;

@@ -111,7 +112,7 @@ class Id {

static Id GetLeastIdForLexicographicComparison();

private:

- friend EntryKernel* UnpackEntry(sql::Statement* statement);

+ friend scoped_ptr<EntryKernel> UnpackEntry(sql::Statement* statement);

friend void BindFields(const EntryKernel& entry,

sql::Statement* statement);

friend std::ostream& operator<<(std::ostream& out, const Id& id);