Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: sync/syncable/syncable_enum_conversions.cc

Issue 10989063: Changed DB to store node positions as Ordinals. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed memory leak error in unittest Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/syncable/syncable_enum_conversions.h ('k') | sync/syncable/syncable_enum_conversions_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/syncable/syncable_enum_conversions.cc
diff --git a/sync/syncable/syncable_enum_conversions.cc b/sync/syncable/syncable_enum_conversions.cc
index 9a8b8921c4162261247f60d6f5f3bb39b1bc9447..3fdd7a8ca406785892bffbbe179aec1839c8b441 100644
--- a/sync/syncable/syncable_enum_conversions.cc
+++ b/sync/syncable/syncable_enum_conversions.cc
@@ -49,7 +49,6 @@ const char* GetInt64FieldString(Int64Field int64_field) {
BASE_VERSION + 1, INT64_FIELDS_END - 1);
switch (int64_field) {
ENUM_CASE(SERVER_VERSION);
- ENUM_CASE(SERVER_POSITION_IN_PARENT);
ENUM_CASE(LOCAL_EXTERNAL_ID);
case INT64_FIELDS_END: break;
}
@@ -148,6 +147,17 @@ const char* GetProtoFieldString(ProtoField proto_field) {
return "";
}
+const char* GetOrdinalFieldString(OrdinalField ordinal_field) {
+ ASSERT_ENUM_BOUNDS(SERVER_ORDINAL_IN_PARENT, SERVER_ORDINAL_IN_PARENT,
+ ORDINAL_FIELDS_BEGIN, ORDINAL_FIELDS_END - 1);
+ switch(ordinal_field) {
+ ENUM_CASE(SERVER_ORDINAL_IN_PARENT);
+ case ORDINAL_FIELDS_END: break;
+ }
+ NOTREACHED();
+ return "";
+}
+
const char* GetBitTempString(BitTemp bit_temp) {
ASSERT_ENUM_BOUNDS(SYNCING, SYNCING,
BIT_TEMPS_BEGIN, BIT_TEMPS_END - 1);
« no previous file with comments | « sync/syncable/syncable_enum_conversions.h ('k') | sync/syncable/syncable_enum_conversions_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698