Split TabRestoreService into InMemoryTRS and PersistentTRS

chrome/browser/sessions/in_memory_tab_restore_service.cc

Index: chrome/browser/sessions/in_memory_tab_restore_service.cc
diff --git a/chrome/browser/sessions/in_memory_tab_restore_service.cc b/chrome/browser/sessions/in_memory_tab_restore_service.cc
new file mode 100644
index 0000000000000000000000000000000000000000..01c038a7d141fa951e9e24ebc1c2dc41d9b639e0
--- /dev/null
+++ b/chrome/browser/sessions/in_memory_tab_restore_service.cc
@@ -0,0 +1,90 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/sessions/in_memory_tab_restore_service.h"
+
+#include "base/compiler_specific.h"
+#include "base/logging.h"
+#include "chrome/browser/sessions/tab_restore_service_factory.h"
+
+InMemoryTabRestoreService::InMemoryTabRestoreService(
+    Profile* profile,
+    TabRestoreService::TimeFactory* time_factory)
+    : ALLOW_THIS_IN_INITIALIZER_LIST(
+        helper_(this, NULL, profile, time_factory)) {
+}
+
+InMemoryTabRestoreService::~InMemoryTabRestoreService() {}
+
+void InMemoryTabRestoreService::AddObserver(
+    TabRestoreServiceObserver* observer) {
+  helper_.AddObserver(observer);
+}
+
+void InMemoryTabRestoreService::RemoveObserver(
+    TabRestoreServiceObserver* observer) {
+  helper_.RemoveObserver(observer);
+}
+
+void InMemoryTabRestoreService::CreateHistoricalTab(
+    content::WebContents* contents,
+    int index) {
+  helper_.CreateHistoricalTab(contents, index);
+}
+
+void InMemoryTabRestoreService::BrowserClosing(
+    TabRestoreServiceDelegate* delegate) {
+  helper_.BrowserClosing(delegate);
+}
+
+void InMemoryTabRestoreService::BrowserClosed(
+    TabRestoreServiceDelegate* delegate) {
+  helper_.BrowserClosed(delegate);
+}
+
+void InMemoryTabRestoreService::ClearEntries() {
+  helper_.ClearEntries();
+}
+
+const TabRestoreService::Entries& InMemoryTabRestoreService::entries() const {
+  return helper_.entries();
+}
+
+void InMemoryTabRestoreService::RestoreMostRecentEntry(
+    TabRestoreServiceDelegate* delegate) {
+  helper_.RestoreMostRecentEntry(delegate);
+}
+
+TabRestoreService::Tab* InMemoryTabRestoreService::RemoveTabEntryById(
+    SessionID::id_type id) {
+  return helper_.RemoveTabEntryById(id);
+}
+
+void InMemoryTabRestoreService::RestoreEntryById(
+    TabRestoreServiceDelegate* delegate,
+    SessionID::id_type id,
+    WindowOpenDisposition disposition) {
+  helper_.RestoreEntryById(delegate, id, disposition);
+}
+
+void InMemoryTabRestoreService::LoadTabsFromLastSession() {
+  NOTIMPLEMENTED();

[sky, 2012/10/25 00:45:44]

NOTIMPLEMENTED doesn't seem right here. I think you want a comment as to why
they do nothing.

[Philippe, 2012/10/25 15:37:07]

Done.

+}
+
+bool InMemoryTabRestoreService::IsLoaded() const {
+  NOTIMPLEMENTED();
+  return true;
+}
+
+void InMemoryTabRestoreService::DeleteLastSession() {
+  NOTIMPLEMENTED();
+}
+
+void InMemoryTabRestoreService::Shutdown() {
+}
+
+ProfileKeyedService* TabRestoreServiceFactory::BuildServiceInstanceFor(
+    Profile* profile) const {
+  return new InMemoryTabRestoreService(profile, NULL);
+}