Split TabRestoreService into InMemoryTRS and PersistentTRS

chrome/browser/sessions/tab_restore_service_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sessions/tab_restore_service_factory.h"
 
 #include "chrome/browser/profiles/profile_dependency_manager.h"
+#include "chrome/browser/sessions/in_memory_tab_restore_service.h"
+#include "chrome/browser/sessions/persistent_tab_restore_service.h"
 #include "chrome/browser/sessions/tab_restore_service.h"
 
 // static
 TabRestoreService* TabRestoreServiceFactory::GetForProfile(Profile* profile) {
   return static_cast<TabRestoreService*>(
       GetInstance()->GetServiceForProfile(profile, true));
 }
 
 // static
 TabRestoreService* TabRestoreServiceFactory::GetForProfileIfExisting(
@@ skipping 14 matching lines @@
 }
 
 TabRestoreServiceFactory::TabRestoreServiceFactory()
     : ProfileKeyedServiceFactory("TabRestoreService",
                                  ProfileDependencyManager::GetInstance()) {
 }
 
 TabRestoreServiceFactory::~TabRestoreServiceFactory() {
 }
 
 ProfileKeyedService* TabRestoreServiceFactory::BuildServiceInstanceFor(

[sky, 2012/10/24 13:51:25]

Can you move this to the corresponding service .cc files so that we don't need
an ifdef.

[Philippe, 2012/10/24 15:42:47]

Good idea.

     Profile* profile) const {
   TabRestoreService* service = NULL;
-  service = new TabRestoreService(profile);
+#ifdef OS_ANDROID
+  // On Android tabs persistence is handled on the Java side.
+  service = new InMemoryTabRestoreService(profile);
+#else
+  service = new PersistentTabRestoreService(profile);
+#endif  // OS_ANDROID
   return service;
 }
 
 bool TabRestoreServiceFactory::ServiceIsNULLWhileTesting() const {
   return true;
 }