Issue 10989011: Defend against NULL pointer dereferences in buggy OpenGL drivers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10989011: Defend against NULL pointer dereferences in buggy OpenGL drivers. (Closed)

Created:
8 years, 2 months ago by Ken Russell (switch to Gerrit)

Modified:
8 years, 2 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, piman, scarybeasts

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Defend against NULL pointer dereferences in buggy OpenGL drivers. BUG=149904 TEST=test case from bug; unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158665

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -16 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		5 chunks	+3 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/10989011/1

8 years, 2 months ago (2012-09-25 18:27:07 UTC) #3

greggman

On 2012/09/25 21:52:16, I haz the power (commit-bot) wrote: > Change committed as 158665 bufferData ...

8 years, 2 months ago (2012-10-18 17:39:26 UTC) #5

greggman

8 years, 2 months ago (2012-10-18 19:28:46 UTC) #6

On 2012/10/18 17:39:26, greggman wrote:
> On 2012/09/25 21:52:16, I haz the power (commit-bot) wrote:
> > Change committed as 158665
> 
> bufferData is 20x faster than bufferSubData on Mac. please revert this!

Okay, I did some tests this morning and _apparently_ this is no longer true. I
know it was when I added that code but maybe the drivers have been fixed. 

So, ignore my previous comment.

LGTM

Expand Messages | Collapse Messages