Issue 10989006: Upstream USB web debugging enabled user pref.

Issue 10989006: Upstream USB web debugging enabled user pref. (Closed)

Created:
8 years, 2 months ago by shashi

Modified:
8 years, 2 months ago

Reviewers:
Nico, nilesh

CC:
chromium-reviews, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upstream USB web debugging enabled user pref. Chrome on Android has a user preference for enabling USB web debugging from Chrome desktop, upstream the preference. BUG=151444 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158505

Patch Set 1 #

Total comments: 2

Patch Set 2 : sort #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -8 lines)			Patch
M	chrome/browser/profiles/profile.cc	View		1 chunk	+7 lines, -0 lines	2 comments	Download
M	chrome/common/pref_names.h	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://chromiumcodereview.appspot.com/10989006/diff/1/chrome/common/pref_names.h File chrome/common/pref_names.h (right): https://chromiumcodereview.appspot.com/10989006/diff/1/chrome/common/pref_names.h#newcode549 chrome/common/pref_names.h:549: extern const char kDevToolsRemoteEnabled[]; Can you order the ...

8 years, 2 months ago (2012-09-24 22:57:17 UTC) #2

shashi

https://chromiumcodereview.appspot.com/10989006/diff/1/chrome/common/pref_names.h File chrome/common/pref_names.h (right): https://chromiumcodereview.appspot.com/10989006/diff/1/chrome/common/pref_names.h#newcode549 chrome/common/pref_names.h:549: extern const char kDevToolsRemoteEnabled[]; On 2012/09/24 22:57:17, Nico wrote: ...

8 years, 2 months ago (2012-09-24 23:21:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/10989006/4002

8 years, 2 months ago (2012-09-24 23:24:13 UTC) #5

Nico

(+pfeldman for devtools advice) https://chromiumcodereview.appspot.com/10989006/diff/4002/chrome/browser/profiles/profile.cc File chrome/browser/profiles/profile.cc (right): https://chromiumcodereview.appspot.com/10989006/diff/4002/chrome/browser/profiles/profile.cc#newcode103 chrome/browser/profiles/profile.cc:103: #endif Actually, should this be ...

8 years, 2 months ago (2012-09-25 01:40:01 UTC) #6

shashi

8 years, 2 months ago (2012-09-25 16:13:11 UTC) #8

https://chromiumcodereview.appspot.com/10989006/diff/4002/chrome/browser/prof...
File chrome/browser/profiles/profile.cc (right):

https://chromiumcodereview.appspot.com/10989006/diff/4002/chrome/browser/prof...
chrome/browser/profiles/profile.cc:103: #endif
This change was already in CQ, at the time of comment, so it was committed, but
I am open to suggestions for moving this preference.
Now, one reason this pref should not be in devtools_window.cc is because it does
not have anything to do with devtools window, the other prefs in that file seem
to be specifically related to the devtools window.

On 2012/09/25 01:40:01, Nico wrote:
> Actually, should this be in chrome/browser/debugger/devtools_window.cc ?
That's
> where most of the remaining devtools prefs get registered.

Expand Messages | Collapse Messages