chromeos: Implement PowerSaveBlocker.

chromeos: Implement PowerSaveBlocker.

This adds a Chrome OS implementation of PowerSaveBlocker to
prevent e.g. the system from suspending during a download or
the screen from dimming while web video is being played.

BUG=114128
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158625

[Daniel Erat, 2012-09-24 23:37:43]

Mike, mind taking a look at this?

Antoine, mind rubber-stamping for content/?

[piman, 2012-09-24 23:45:00]

+jam 
I would have imagined that this sort of feature would belong more in chrome than
in content, but apparently it's there on other platforms. John, you have
thoughts about adding chromeos/ here?
Other than that, the code looks fine.

[Mike Mammarella, 2012-09-24 23:58:27]

LGTM

IIRC, this code originally lived in chrome, and it got moved to content. :)

[jam, 2012-09-25 07:08:33]

I'm a little wary of adding a new dependency from content, especially on
chromeos. From what I understand, in the future chromeos will consume content as
features like panels move from src/chrome to src/chromeos. This will mean
there's a circular dependency.

So I'm leaning towards doing this through the Content API (i.e. the current way
of getting "out" of content) instead of adding a dependency on chromeos.

[jam, 2012-09-25 16:00:17]

On 2012/09/25 07:08:33, John Abd-El-Malek wrote:
> I'm a little wary of adding a new dependency from content, especially on
> chromeos. From what I understand, in the future chromeos will consume content
as
> features like panels move from src/chrome to src/chromeos. This will mean
> there's a circular dependency.
> 
> So I'm leaning towards doing this through the Content API (i.e. the current
way
> of getting "out" of content) instead of adding a dependency on chromeos.

ok, i've been thinking about this mroe and chatted with Ben as well.

i'm now not as against including src/chromeos as before, since Ben convinced me
it's just like including system headers on other platforms. can you make the
DEPS more specific, i.e. just edit content/browser/DEPS, and for now only allow
"chromeos/power"?

[Daniel Erat, 2012-09-25 16:07:29]

On 2012/09/25 16:00:17, John Abd-El-Malek wrote:
> On 2012/09/25 07:08:33, John Abd-El-Malek wrote:
> > I'm a little wary of adding a new dependency from content, especially on
> > chromeos. From what I understand, in the future chromeos will consume
content
> as
> > features like panels move from src/chrome to src/chromeos. This will mean
> > there's a circular dependency.
> > 
> > So I'm leaning towards doing this through the Content API (i.e. the current
> way
> > of getting "out" of content) instead of adding a dependency on chromeos.
> 
> ok, i've been thinking about this mroe and chatted with Ben as well.
> 
> i'm now not as against including src/chromeos as before, since Ben convinced
me
> it's just like including system headers on other platforms. can you make the
> DEPS more specific, i.e. just edit content/browser/DEPS, and for now only
allow
> "chromeos/power"?

Sure thing; uploaded a new version.

[jam, 2012-09-25 16:17:40]

lgtm

[commit-bot: I haz the power, 2012-09-25 16:42:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10988011/5002

[commit-bot: I haz the power, 2012-09-25 18:54:00]

Change committed as 158625