Issue 10988007: Bluetooth: test device connection during discovery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10988007: Bluetooth: test device connection during discovery (Closed)

Created:
8 years, 3 months ago by keybuk

Modified:
8 years, 2 months ago

Reviewers:
bryeung, satorux1, sky

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Bluetooth: test device connection during discovery Some Bluetooth devices connect back to the host during discovery in order to obtain host SDP information; we had a bug where we would remove the objects for them rather than reverting back from a connected to discovered device. Add unit tests to verify that this bug is fixed. BUG=chromium-os:31629 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158631

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -0 lines)			Patch
	A	chrome/browser/chromeos/bluetooth/bluetooth_adapter_devices_unittest.cc	View		1 chunk	+208 lines, -0 lines	0 comments	Download
	M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/10988007/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/10988007/diff/1/chrome/chrome_tests.gypi#newcode1092 chrome/chrome_tests.gypi:1092: 'browser/chromeos/bluetooth/bluetooth_adapter_devices_unittest.cc', sort

8 years, 3 months ago (2012-09-25 00:18:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/10988007/1

8 years, 2 months ago (2012-09-25 17:30:01 UTC) #4

Change committed as 158631

Expand Messages | Collapse Messages