Issue 10987086: MIPS: Fix issue 2346 (order of operations in keyed store on arrays) and turn get-own-property-descr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10987086: MIPS: Fix issue 2346 (order of operations in keyed store on arrays) and turn get-own-property-descr… (Closed)

Created:
8 years, 2 months ago by palfia

Modified:
8 years, 2 months ago

Reviewers:
kisg, Paul Lind, Erik Corry, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix issue 2346 (order of operations in keyed store on arrays) and turn get-own-property-descriptor.js test into a regression test. Port r12604 (ae837167) BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12741

Patch Set 1 #

Patch Set 2 : Rebased on r12646 #

Patch Set 3 : Rebased on r12737 and fixed typos #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -119 lines)			Patch
	M	src/mips/ic-mips.cc	View	1 2	5 chunks	+153 lines, -119 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danno

8 years, 2 months ago (2012-10-16 08:27:47 UTC) #4

LGTM with a nit that I'll fix when I land.

https://chromiumcodereview.appspot.com/10987086/diff/6001/src/mips/ic-mips.cc
File src/mips/ic-mips.cc (right):

https://chromiumcodereview.appspot.com/10987086/diff/6001/src/mips/ic-mips.cc...
src/mips/ic-mips.cc:1415: &slow, kCheckMap, kDontIncrementLength,
nit: spacing. I'll fix when I land.

Expand Messages | Collapse Messages