Issue 10987078: Enforce --enable-pinch flag on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10987078: Enforce --enable-pinch flag on Windows. (Closed)

Created:
8 years, 2 months ago by Jeff Timanus

Modified:
8 years, 2 months ago

Reviewers:
rjkroege, vangelis, Nico, (unused - use chromium)

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disable pinch-zoom gesture by default on windows builds. Pinch can be re-enabled by passing --enable-pinch on the command line. The compositor based pinch zoom, and existing gesture-based pinch zoom isn't ready for prime time. BUG=148816 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159151

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_win.cc	View		2 chunks	+15 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jeff Timanus

PTAL. I want to disable the pinch gesture support on windows (as it is on ...

8 years, 2 months ago (2012-09-27 19:57:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/twiz@chromium.org/10987078/1

8 years, 2 months ago (2012-09-27 21:29:01 UTC) #3

Nico

8 years, 2 months ago (2012-09-28 04:00:13 UTC) #5

lgtm

https://chromiumcodereview.appspot.com/10987078/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

https://chromiumcodereview.appspot.com/10987078/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_view_win.cc:385:
CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnablePinch);
nit: HasSwitch() should be fast, no need to make this static

Expand Messages | Collapse Messages