Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10987077: Enable FtpDirectoryListing* GUnit tests on Android. (Closed)

Created:
8 years, 2 months ago by Philippe
Modified:
8 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, Paweł Hajdan Jr., bulach+watch_chromium.org, peter+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Enable FtpDirectoryListing* GUnit tests on Android. This is part of Chrome for Android upstreaming. BUG=136750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159339

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Yaron's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/android/gtest_filter/net_unittests_disabled View 2 chunks +0 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_windows_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Philippe
8 years, 2 months ago (2012-09-27 23:34:54 UTC) #1
Philippe
+Yaron
8 years, 2 months ago (2012-09-27 23:43:04 UTC) #2
Yaron
lgtm https://chromiumcodereview.appspot.com/10987077/diff/1/net/ftp/ftp_directory_listing_parser_windows_unittest.cc File net/ftp/ftp_directory_listing_parser_windows_unittest.cc (right): https://chromiumcodereview.appspot.com/10987077/diff/1/net/ftp/ftp_directory_listing_parser_windows_unittest.cc#newcode46 net/ftp/ftp_directory_listing_parser_windows_unittest.cc:46: #endif // !defined (OS_LINUX) update comment
8 years, 2 months ago (2012-09-28 00:03:40 UTC) #3
Philippe
https://chromiumcodereview.appspot.com/10987077/diff/1/net/ftp/ftp_directory_listing_parser_windows_unittest.cc File net/ftp/ftp_directory_listing_parser_windows_unittest.cc (right): https://chromiumcodereview.appspot.com/10987077/diff/1/net/ftp/ftp_directory_listing_parser_windows_unittest.cc#newcode46 net/ftp/ftp_directory_listing_parser_windows_unittest.cc:46: #endif // !defined (OS_LINUX) On 2012/09/28 00:03:41, Yaron wrote: ...
8 years, 2 months ago (2012-09-28 00:08:35 UTC) #4
Paweł Hajdan Jr.
LGTM
8 years, 2 months ago (2012-09-28 06:57:51 UTC) #5
bulach
lgtm, thanks!
8 years, 2 months ago (2012-09-28 10:03:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10987077/10001
8 years, 2 months ago (2012-09-28 18:53:45 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-28 21:24:07 UTC) #8 
Change committed as 159339

Powered by Google App Engine
This is Rietveld 408576698