net/proxy/proxy_info.h - Issue 10987043: Receiving Connection: Proxy-Bypass induces proxy fallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_info.h

Issue 10987043: Receiving Connection: Proxy-Bypass induces proxy fallback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pull proxy list mutation in ProxyService. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_info.h

diff --git a/net/proxy/proxy_info.h b/net/proxy/proxy_info.h

index e02ba8b2b2c6f5eeca942771630b9d3d265b4145..ed4e8a271819145e706567e3f179651de36f1173 100644

--- a/net/proxy/proxy_info.h

+++ b/net/proxy/proxy_info.h

@@ -110,6 +110,11 @@ class NET_EXPORT ProxyInfo {

// available to try in proxy list_.

bool Fallback(const BoundNetLog& net_log);

+ // Marks the current proxy as bad and records the addition in the given

+ // |proxy_retry_info|.

+ bool Fallback(ProxyRetryInfoMap& proxy_retry_info,

eroman 2012/09/26 22:01:58 Our style is to use pointers for mutable state --

Michael Piatek 2012/09/27 00:30:24 Done.

+ const BoundNetLog& net_log);

// De-prioritizes the proxies that we have cached as not working, by moving

// them to the end of the proxy list.

void DeprioritizeBadProxies(const ProxyRetryInfoMap& proxy_retry_info);

« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/proxy/proxy_info.cc » ('j') | no next file with comments »