Receiving Connection: Proxy-Bypass induces proxy fallback.

net/proxy/proxy_service.cc

Index: net/proxy/proxy_service.cc
diff --git a/net/proxy/proxy_service.cc b/net/proxy/proxy_service.cc
index 9989b8221cdc09944ce3e14622d3d088851b6f7e..7f989483f06b99a456f831ea92981254fdd412a0 100644
--- a/net/proxy/proxy_service.cc
+++ b/net/proxy/proxy_service.cc
@@ -1174,6 +1174,12 @@ int ProxyService::ReconsiderProxyAfterError(const GURL& url,
   return did_fallback ? OK : ERR_FAILED;
 }
 
+bool ProxyService::Fallback(const ProxyInfo& result,
+                            const BoundNetLog& net_log) {
+  result.proxy_list_.UpdateRetryInfoOnFallback(&proxy_retry_info_, net_log);
+  return result.proxy_list_.size() > 1;

[eroman, 2012/09/28 23:19:15]

According to the documentation in header, I expect this to return true when
proxy_list_.size() >= 1 (which is the return value from
UpdateRetryInfoOnFallback).

Can you explain why this needs to be strictly greater than 1?

[Michael Piatek, 2012/10/01 23:23:11]

Done.

+}
+
 void ProxyService::ReportSuccess(const ProxyInfo& result) {
   DCHECK(CalledOnValidThread());