Receiving Connection: Proxy-Bypass induces proxy fallback.

net/proxy/proxy_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_INFO_H_
 #define NET_PROXY_PROXY_INFO_H_
 
 #include <string>
 
 #include "net/base/net_export.h"
@@ skipping 92 matching lines @@
   // Returns the source for configuration settings used for proxy resolution.
   ProxyConfigSource config_source() const { return config_source_; }
 
   // See description in ProxyList::ToPacString().
   std::string ToPacString() const;
 
   // Marks the current proxy as bad. Returns true if there is another proxy
   // available to try in proxy list_.
   bool Fallback(const BoundNetLog& net_log);
 
+  // Marks the current proxy as bad and records the addition in the given
+  // |proxy_retry_info|.
+  bool Fallback(ProxyRetryInfoMap& proxy_retry_info,

[eroman, 2012/09/26 22:01:58]

Our style is to use pointers for mutable state -- please use a pointer here.

[Michael Piatek, 2012/09/27 00:30:24]

Done.

+                const BoundNetLog& net_log);
+
   // De-prioritizes the proxies that we have cached as not working, by moving
   // them to the end of the proxy list.
   void DeprioritizeBadProxies(const ProxyRetryInfoMap& proxy_retry_info);
 
   // Deletes any entry which doesn't have one of the specified proxy schemes.
   void RemoveProxiesWithoutScheme(int scheme_bit_field);
 
  private:
   friend class ProxyService;
 
@@ skipping 20 matching lines @@
   // Whether the proxy result represent a proxy bypass.
   bool did_bypass_proxy_;
 
   // Whether we used a PAC script for resolving the proxy.
   bool did_use_pac_script_;
 };
 
 }  // namespace net
 
 #endif  // NET_PROXY_PROXY_INFO_H_