Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: lib/html/scripts/systembase.py

Issue 10987042: Speed up fremontcut/dartdomgenerator (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/scripts/idlnode.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systembase.py
diff --git a/lib/html/scripts/systembase.py b/lib/html/scripts/systembase.py
index 700d412430fb4bf75fdeba6787c7b5f376de32d4..97b94d759cb750bd0e172f4ff8f0bf4e25ebbad7 100644
--- a/lib/html/scripts/systembase.py
+++ b/lib/html/scripts/systembase.py
@@ -78,7 +78,7 @@ class BaseGenerator(object):
for const in sorted(interface.constants, ConstantOutputOrder):
self.AddConstant(const)
- for attr in interface.attributes:
+ for attr in sorted(interface.attributes, ConstantOutputOrder):
if attr.type.id != 'EventListener':
self.AddAttribute(attr)
@@ -113,7 +113,7 @@ class BaseGenerator(object):
for parent_interface in secondary_parents:
if isinstance(parent_interface, str): # IsDartCollectionType(parent_interface)
continue
- for attr in parent_interface.attributes:
+ for attr in sorted(parent_interface.attributes, ConstantOutputOrder):
if not FindMatchingAttribute(interface, attr):
self.AddSecondaryAttribute(parent_interface, attr)
« no previous file with comments | « lib/html/scripts/idlnode.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698