Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5888)

Unified Diff: chrome/browser/performance_monitor/performance_monitor_util.cc

Issue 10987040: Fix CPM casting issue; refactor renderer crash events (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Nit fixes, latest master Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/performance_monitor_util.cc
diff --git a/chrome/browser/performance_monitor/performance_monitor_util.cc b/chrome/browser/performance_monitor/performance_monitor_util.cc
index 505381fa33e791cf995885fe844bf5c60f8c6abb..6c937191a6b48f8e15f4cddd3585f26f923c208f 100644
--- a/chrome/browser/performance_monitor/performance_monitor_util.cc
+++ b/chrome/browser/performance_monitor/performance_monitor_util.cc
@@ -48,22 +48,13 @@ scoped_ptr<Event> CreateExtensionEvent(const EventType type,
type, time, value.Pass()));
}
-scoped_ptr<Event> CreateRendererFreezeEvent(const base::Time& time,
- const std::string& url) {
- events::RendererFreeze event;
- event.event_type = EVENT_RENDERER_FREEZE;
- event.time = static_cast<double>(time.ToInternalValue());
- event.url = url;
- scoped_ptr<base::DictionaryValue> value = event.ToValue();
- return scoped_ptr<Event>(new Event(
- EVENT_RENDERER_FREEZE, time, value.Pass()));
-}
-
-scoped_ptr<Event> CreateCrashEvent(const base::Time& time,
- const EventType& type) {
- events::RendererCrash event;
+scoped_ptr<Event> CreateRendererFailureEvent(const base::Time& time,
+ const EventType& type,
+ const std::string& url) {
+ events::RendererFailure event;
event.event_type = type;
event.time = static_cast<double>(time.ToInternalValue());
+ event.url = url;
scoped_ptr<base::DictionaryValue> value = event.ToValue();
return scoped_ptr<Event>(new Event(type, time, value.Pass()));
}

Powered by Google App Engine
This is Rietveld 408576698