Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: chrome/browser/performance_monitor/metric.h

Issue 10987040: Fix CPM casting issue; refactor renderer crash events (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Nit fixes, latest master Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/metric.h
diff --git a/chrome/browser/performance_monitor/metric.h b/chrome/browser/performance_monitor/metric.h
index 79b9ed7c75e644180a774374408c6e875e86fc8a..a7772ec6aafacf4a717c186e65172fa118d3a5e7 100644
--- a/chrome/browser/performance_monitor/metric.h
+++ b/chrome/browser/performance_monitor/metric.h
@@ -17,16 +17,26 @@ namespace performance_monitor {
// - Add the appropriate functions in
// chrome/browser/ui/webui/performance_monitor/performance_monitor_l10n.h.
enum MetricType {
-METRIC_UNDEFINED,
-METRIC_CPU_USAGE,
-METRIC_PRIVATE_MEMORY_USAGE,
-METRIC_SHARED_MEMORY_USAGE,
-METRIC_STARTUP_TIME,
-METRIC_TEST_STARTUP_TIME,
-METRIC_SESSION_RESTORE_TIME,
-METRIC_PAGE_LOAD_TIME,
-METRIC_NETWORK_BYTES_READ,
-METRIC_NUMBER_OF_METRICS
+ METRIC_UNDEFINED,
+
+ // CPU and memory usage are combined for all Chrome-related processes.
+ METRIC_CPU_USAGE,
+ METRIC_PRIVATE_MEMORY_USAGE,
+ METRIC_SHARED_MEMORY_USAGE,
+
+ // Timing measurements; these are all independent metrics (e.g., session
+ // restore time is independent of startup time, even though they may happen
+ // in sequence). Test startup time refers to any non-normal startup time, e.g.
+ // when we run test suites.
+ METRIC_STARTUP_TIME,
+ METRIC_TEST_STARTUP_TIME,
+ METRIC_SESSION_RESTORE_TIME,
+ METRIC_PAGE_LOAD_TIME,
+
+ // Total number of bytes read since PerformanceMonitor first started running.
+ METRIC_NETWORK_BYTES_READ,
+
+ METRIC_NUMBER_OF_METRICS
};
struct Metric {
« no previous file with comments | « chrome/browser/performance_monitor/key_builder.cc ('k') | chrome/browser/performance_monitor/performance_monitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698