Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: chrome/browser/performance_monitor/events.json

Issue 10987040: Fix CPM casting issue; refactor renderer crash events (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Nit fixes, latest master Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/performance_monitor/event.h ('k') | chrome/browser/performance_monitor/key_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/performance_monitor/events.json
diff --git a/chrome/browser/performance_monitor/events.json b/chrome/browser/performance_monitor/events.json
index 9ac70f18c9cbc1c1d1e6ed01d678d6ec5e44a26f..ab5ffc6142647346ca0f7ce54586a5a3b2302642 100644
--- a/chrome/browser/performance_monitor/events.json
+++ b/chrome/browser/performance_monitor/events.json
@@ -33,22 +33,13 @@
}
},
{
- "id": "RendererCrash",
+ "id": "RendererFailure",
"type": "object",
- "description": "The event to represent a renderer crash.",
- "properties": {
- "eventType": {"type": "integer", "description": "The type of the event."},
- "time": {"type": "number", "description": "The time at which the event was recorded."}
- }
- },
- {
- "id": "RendererFreeze",
- "type": "object",
- "description": "The event to represent a frozen renderer (when the frozen tab popup comes up).",
+ "description": "The event to represent a renderer hanging, crashing, or being killed.",
"properties": {
"eventType": {"type": "integer", "description": "The type of the event."},
"time": {"type": "number", "description": "The time at which the event was recorded."},
- "url": {"type": "string", "description": "The crash url."}
+ "url": {"type": "string", "description": "The url (or urls) associated with the renderer failure, if available (if unavailable, this is empty)."}
}
},
{
« no previous file with comments | « chrome/browser/performance_monitor/event.h ('k') | chrome/browser/performance_monitor/key_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698