Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 10987038: Change a result code ENUM value to help diagnose unexpected histogram data (Closed)

Created:
8 years, 2 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Change a result code ENUM value to help diagnose unexpected histogram data We've gotten histogram data showing the integer value of 24, which happens to be the same as RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR, as the exit code for some renderer crashes. This seems impossible since that result code should only be used for browser process exit very early in startup, when a special --install-from-webstore experimental command line flag is present. What seems more likely is that some other exit values are getting conflated with this one somewhere in the reporting pipeline, perhaps because it comes last in the list. To verify this hypothesis, I'm changing the name and value of RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR, adding a dummy value in its place, as well as following it with another dummy value. BUG=152285 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_result_codes.h View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
asargent_no_longer_on_chrome
8 years, 2 months ago (2012-09-25 22:35:11 UTC) #1
rvargas (doing something else)
lgtm
8 years, 2 months ago (2012-09-25 22:40:53 UTC) #2
asargent_no_longer_on_chrome
+thakis for OWNERS review
8 years, 2 months ago (2012-09-25 22:57:56 UTC) #3
Nico
lgtm
8 years, 2 months ago (2012-09-26 02:57:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10987038/1
8 years, 2 months ago (2012-09-26 03:08:15 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 08:48:26 UTC) #6
Change committed as 158769

Powered by Google App Engine
This is Rietveld 408576698