Need some keyboard shortcut for fullscreen: Shift-F4

Notes:
F4 was recently changed to toggle between Maximize/Restored unless in Fullscreen. In Fullscreen F4 toggles out of it.
This fix adds Shift-F4 to toggle Fullscreen (as F4 used to do).
TOGGLE_MAXIMIZED must be in kReservedActions in ash/accelerators/accelerator_table.cc. It was recently removed.

BUG=151544
TEST=Press Shift F4 to toggle fullscreen; Ctrl-Alt-/ for keyboard overlay, then Shift.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158811

[sschmitz, 2012-09-25 19:16:12]

Reviewing:

yusuke: overall

sky: owner for
chrome/browser/ui/views/accelerator_table.cc
ash/accelerators/accelerator_table.cc

xiyuan: owner for
chrome/browser/resources/chromeos/keyboard_overlay_data.js
chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

cpu: owner for
chrome/app/generated_resources.grd

[Yusuke Sato, 2012-09-25 19:41:42]

http://codereview.chromium.org/10987034/diff/1/ash/accelerators/accelerator_t...
File ash/accelerators/accelerator_table.cc (right):

http://codereview.chromium.org/10987034/diff/1/ash/accelerators/accelerator_t...
ash/accelerators/accelerator_table.cc:181: TOGGLE_MAXIMIZED,
I removed TOGGLE_MAXIMIZED for crbug.com/152060. could you let me know why this
has to be reserved?

[sschmitz, 2012-09-25 20:48:31]

On 2012/09/25 19:41:42, Yusuke Sato wrote:
>
http://codereview.chromium.org/10987034/diff/1/ash/accelerators/accelerator_t...
> File ash/accelerators/accelerator_table.cc (right):
> 
>
http://codereview.chromium.org/10987034/diff/1/ash/accelerators/accelerator_t...
> ash/accelerators/accelerator_table.cc:181: TOGGLE_MAXIMIZED,
> I removed TOGGLE_MAXIMIZED for crbug.com/152060. could you let me know why
this
> has to be reserved?
Per discussion with Yusuke: For now the 'reservation' is needed. I filed
crbug.com/152265 on Yusuke's request regarding this.

[Yusuke Sato, 2012-09-25 20:50:35]

lgtm

On 2012/09/25 20:48:31, sschmitz wrote:
> On 2012/09/25 19:41:42, Yusuke Sato wrote:
> >
>
http://codereview.chromium.org/10987034/diff/1/ash/accelerators/accelerator_t...
> > File ash/accelerators/accelerator_table.cc (right):
> > 
> >
>
http://codereview.chromium.org/10987034/diff/1/ash/accelerators/accelerator_t...
> > ash/accelerators/accelerator_table.cc:181: TOGGLE_MAXIMIZED,
> > I removed TOGGLE_MAXIMIZED for crbug.com/152060. could you let me know why
> this
> > has to be reserved?
> Per discussion with Yusuke: For now the 'reservation' is needed. I filed
> crbug.com/152265 on Yusuke's request regarding this.

[xiyuan, 2012-09-25 20:51:15]

chrome/browser/resources/chromeos/keyboard_overlay_data.js
chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

LGTM

[sschmitz, 2012-09-25 20:52:43]

https://chromiumcodereview.appspot.com/10987034/diff/1/ash/accelerators/accel...
File ash/accelerators/accelerator_table.cc (right):

https://chromiumcodereview.appspot.com/10987034/diff/1/ash/accelerators/accel...
ash/accelerators/accelerator_table.cc:181: TOGGLE_MAXIMIZED,
On 2012/09/25 19:41:42, Yusuke Sato wrote:
> I removed TOGGLE_MAXIMIZED for crbug.com/152060. could you let me know why
this
> has to be reserved?
Without it, F4 toggles fullscreen (i.e. the Chrome shortcut takes precedence)

[sky, 2012-09-25 21:45:42]

LGTM

[commit-bot: I haz the power, 2012-09-25 23:16:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/10987034/1

[commit-bot: I haz the power, 2012-09-26 00:15:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/10987034/1

[commit-bot: I haz the power, 2012-09-26 01:11:45]

Retried try job too often for step(s) build

[commit-bot: I haz the power, 2012-09-26 15:06:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/10987034/2004

[commit-bot: I haz the power, 2012-09-26 15:32:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/10987034/2004

[commit-bot: I haz the power, 2012-09-26 16:35:32]

Change committed as 158811