Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2741)

Unified Diff: chrome/browser/resources/net_internals/source_row.js

Issue 10987030: Make about:net-internal's filters work a bit better. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Response to comments, retry upload (First corrupt?) Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/source_row.js
===================================================================
--- chrome/browser/resources/net_internals/source_row.js (revision 158398)
+++ chrome/browser/resources/net_internals/source_row.js (working copy)
@@ -177,8 +177,13 @@
// Check source type, if needed.
if (filter.type) {
+ var i;
var sourceType = this.sourceEntry_.getSourceTypeString().toLowerCase();
- if (filter.type.indexOf(sourceType) == -1)
+ for (i = 0; i < filter.type.length; ++i) {
+ if (sourceType.search(filter.type[i]) != -1)
+ break;
+ }
+ if (i == filter.type.length)
return false;
}
@@ -200,8 +205,10 @@
if (sourceType.toLowerCase().indexOf(filter.text) != -1)
return true;
- var entryText = JSON.stringify(this.sourceEntry_.getLogEntries());
- return entryText.toLowerCase().indexOf(filter.text) != -1;
+ return searchLogEntriesForText(
+ filter.text,
+ this.sourceEntry_.getLogEntries(),
+ SourceTracker.getInstance().getPrivacyStripping());
},
isSelected: function() {

Powered by Google App Engine
This is Rietveld 408576698