Make about:net-internal's filters work a bit better.

Make about:net-internal's filters work a bit better.

Text filters now search through the TablePrinter,
rather than unformatted JSON.

To search for multiple types/ids, comma delimited
lists must now be used rather than multiple "type:"
or "id:" arguments.  Doubt anyone used this feature
before, and the new behavior makes testing easier.

Filtering by type also does substring matching now.

R=eroman@chromium.org
TBR=jhawkins@chromium.org
BUG=115977
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158675

[mmenke, 2012-09-25 19:38:03]

Want to do a follow up CL, either implementing incremental filtering or just
cleaning up the filtering code.  Filtering only depends on values within
SourceEntry, and separating it out from SourceRow would make testing just
filtering a little cleaner.

Despite the O(n^2) sets of filters the new test uses, it seems to run pretty
quickly, since it does everything synchronously.  Run times looked fine on OSX
and Linux, but still want to keep an eye on how it performs on Win8, just in
case.

[eroman, 2012-09-25 19:59:21]

LGTM.

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/events_view.js (right):

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/events_view.js:300: return
filter[directive].indexOf(string) > -1;
nit: i prefer "!= -1"

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/log_view_painter.js:40: * DOM.
Can you mention the return value?

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/log_view_painter.js:51: * Creates
TablePrinters for use by the above two functions.
nit: TablePrinters --> TablePrinter ?

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/source_row.js (right):

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/source_row.js:180: var i;
no need to change this, but I did want to point out that "var i" inside the for
loop would still be accessible outside of it. Oh Javascript.

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/table_printer.js (right):

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/table_printer.js:127: if
(cell.text.toLowerCase().indexOf(searchString) >= 0)
[optional] i prefer != -1

[mmenke, 2012-09-25 20:12:24]

Thanks for the feedback.

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/events_view.js (right):

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/events_view.js:300: return
filter[directive].indexOf(string) > -1;
On 2012/09/25 19:59:21, eroman wrote:
> nit: i prefer "!= -1"

Done.

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/log_view_painter.js:40: * DOM.
On 2012/09/25 19:59:21, eroman wrote:
> Can you mention the return value?

Done (Also now mention that searchString much be lowercase)

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/log_view_painter.js:51: * Creates
TablePrinters for use by the above two functions.
On 2012/09/25 19:59:21, eroman wrote:
> nit: TablePrinters --> TablePrinter ?

Done.

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/source_row.js (right):

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/source_row.js:180: var i;
On 2012/09/25 19:59:21, eroman wrote:
> no need to change this, but I did want to point out that "var i" inside the
for
> loop would still be accessible outside of it. Oh Javascript.

Yea, realized that when I wrote the code.  Didn't seem to be anything I could do
to make things nicer, though.

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/table_printer.js (right):

http://codereview.chromium.org/10987030/diff/2001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/table_printer.js:127: if
(cell.text.toLowerCase().indexOf(searchString) >= 0)
On 2012/09/25 19:59:21, eroman wrote:
> [optional] i prefer != -1

Done.

[commit-bot: I haz the power, 2012-09-25 20:27:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10987030/12002

[commit-bot: I haz the power, 2012-09-25 20:27:44]

Presubmit check for 10987030-12002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 2.0s to calculate.

[commit-bot: I haz the power, 2012-09-25 20:29:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10987030/12002

[commit-bot: I haz the power, 2012-09-25 22:40:50]

Change committed as 158675