Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 10987018: Share Font Code for New Autofill. (Closed)

Created:
8 years, 2 months ago by csharp
Modified:
8 years, 2 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, browser-components-watch_chromium.org, dyu1, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Share Font Code for New Autofill. Move the gfx::Font code into the base class to allow the platform specific subclasses to share it. BUG=51644 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158684

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M chrome/browser/autofill/autofill_popup_view.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_popup_view.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc View 5 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
csharp
erg@ for gtk section isherman@ for autofill section. I have a follow up views cl ...
8 years, 2 months ago (2012-09-25 14:31:24 UTC) #1
tfarina
http://codereview.chromium.org/10987018/diff/1/chrome/browser/autofill/autofill_popup_view.h File chrome/browser/autofill/autofill_popup_view.h (right): http://codereview.chromium.org/10987018/diff/1/chrome/browser/autofill/autofill_popup_view.h#newcode74 chrome/browser/autofill/autofill_popup_view.h:74: const gfx::Font label_font() const { return label_font_; } return ...
8 years, 2 months ago (2012-09-25 16:00:58 UTC) #2
csharp
http://codereview.chromium.org/10987018/diff/1/chrome/browser/autofill/autofill_popup_view.h File chrome/browser/autofill/autofill_popup_view.h (right): http://codereview.chromium.org/10987018/diff/1/chrome/browser/autofill/autofill_popup_view.h#newcode74 chrome/browser/autofill/autofill_popup_view.h:74: const gfx::Font label_font() const { return label_font_; } On ...
8 years, 2 months ago (2012-09-25 20:08:00 UTC) #3
Elliot Glaysher
gtk lgtm
8 years, 2 months ago (2012-09-25 20:54:31 UTC) #4
Ilya Sherman
lgtm
8 years, 2 months ago (2012-09-25 21:20:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10987018/5001
8 years, 2 months ago (2012-09-25 21:20:30 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 23:17:58 UTC) #7
Change committed as 158684

Powered by Google App Engine
This is Rietveld 408576698