Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 10987005: Autohide behavior simplified to always/never (Closed)

Created:
8 years, 3 months ago by Harry McCleave
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Autohide behavior simplified to always/never BUG=146773 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -77 lines) Patch
M ash/launcher/launcher_context_menu.cc View 1 chunk +4 lines, -23 lines 0 comments Download
M ash/launcher/launcher_context_menu_unittest.cc View 1 chunk +7 lines, -11 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/screen_ash_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 5 chunks +4 lines, -10 lines 0 comments Download
M ash/wm/shelf_types.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_manager2_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Harry McCleave
Ready for a review (revert has landed) here is patch -string id change (so current ...
8 years, 3 months ago (2012-09-24 23:24:55 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-25 00:01:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10987005/1
8 years, 3 months ago (2012-09-25 00:03:43 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) crypto_unittests, unit_tests, cacheinvalidation_unittests, remoting_unittests, jingle_unittests, nacl_integration, ipc_tests, interactive_ui_tests, ...
8 years, 3 months ago (2012-09-25 00:12:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10987005/1
8 years, 2 months ago (2012-09-25 18:13:30 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 20:26:25 UTC) #6
Change committed as 158639

Powered by Google App Engine
This is Rietveld 408576698