Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 10986094: Make java.gypi use all_dependent_settings for input_jars_paths (Closed)

Created:
8 years, 2 months ago by cjhopman
Modified:
8 years, 2 months ago
Reviewers:
Yaron, sky, Ryan Sleevi, brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@apk_combine
Visibility:
Public.

Description

Make java.gypi use all_dependent_settings for input_jars_paths all_dependent_settings is more like the link_settings that we would like to use here. This variable is used by java targets to set the classpath for javac, i.e. to set the libraries that are needed by the target. Use of direct_dependent_settings with export_dependent_settings causes unnecessary duplication of all java dependencies for all of our java library targets. BUG=146049 TBR=sky,brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160768

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -45 lines) Patch
M base/base.gyp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/java.gypi View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_android.gypi View 1 1 chunk +3 lines, -5 lines 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +4 lines, -8 lines 0 comments Download
M net/net.gyp View 1 3 chunks +0 lines, -11 lines 0 comments Download
M ui/ui.gyp View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cjhopman
8 years, 2 months ago (2012-09-28 20:05:33 UTC) #1
Yaron
lgtm
8 years, 2 months ago (2012-09-28 20:15:03 UTC) #2
cjhopman
rsleevi: net/ Also, you originally objected to all_dependent_settings so I figure I should get your ...
8 years, 2 months ago (2012-10-08 17:44:46 UTC) #3
Ryan Sleevi
net/ LGTM. Assuming I've read correctly, this only affects the Java targets, and is being ...
8 years, 2 months ago (2012-10-08 17:50:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10986094/11002
8 years, 2 months ago (2012-10-08 23:59:12 UTC) #5
commit-bot: I haz the power
Presubmit check for 10986094-11002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-08 23:59:20 UTC) #6
cjhopman
TBR: only affects android gyp targets sky: ui/, chrome/ brettw: base/, content/
8 years, 2 months ago (2012-10-09 00:03:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10986094/11002
8 years, 2 months ago (2012-10-09 00:03:54 UTC) #8
sky
LGTM
8 years, 2 months ago (2012-10-09 00:33:59 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-09 02:20:35 UTC) #10
Change committed as 160768

Powered by Google App Engine
This is Rietveld 408576698