Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 10986080: Linux: fix build with system ICU. (Closed)

Created:
8 years, 2 months ago by Paweł Hajdan Jr.
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: fix build with system ICU. This is upstreaming Gentoo Linux patch, fixing breakage from https://chromiumcodereview.appspot.com/10941025/ TBR=vitalybuka,abodenha BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M printing/backend/print_backend.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/10986080/1
8 years, 2 months ago (2012-09-28 08:09:44 UTC) #1
commit-bot: I haz the power
Change committed as 159235
8 years, 2 months ago (2012-09-28 10:27:11 UTC) #2
Paweł Hajdan Jr.
TBR Please note how to properly include ICU headers.
8 years, 2 months ago (2012-09-28 13:52:13 UTC) #3
Albert Bodenhamer
lgtm
8 years, 2 months ago (2012-09-28 16:37:03 UTC) #4
Vitaly Buka (NO REVIEWS)
8 years, 2 months ago (2012-09-28 17:40:45 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698