Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 10986059: Fail incoming requests in PepperFlashSettingsManager after an error. (Closed)

Created:
8 years, 2 months ago by Bernhard Bauer
Modified:
8 years, 2 months ago
Reviewers:
brettw, yzshen1
CC:
chromium-reviews, engedy
Visibility:
Public.

Description

Fail incoming requests in PepperFlashSettingsManager after an error. This is the second of two CLs to address the issue mentioned below. It is in itself enough in itself to fix the issue, but given that the issue actually discovered two bugs, there is an other CL to fix the other bug too. See issue for details. BUG=144874 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159569

Patch Set 1 #

Patch Set 2 : fix? #

Total comments: 4

Patch Set 3 : review #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -73 lines) Patch
M chrome/browser/pepper_flash_settings_manager.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 1 2 39 chunks +98 lines, -71 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Bernhard Bauer
Please review.
8 years, 2 months ago (2012-09-29 07:45:24 UTC) #1
yzshen1
Thanks a lot for fixing this bug! I am sorry for all the trouble. This ...
8 years, 2 months ago (2012-09-30 18:19:15 UTC) #2
yzshen1
> I am sorry for all the trouble. This is not the second time I ...
8 years, 2 months ago (2012-09-30 18:23:22 UTC) #3
Bernhard Bauer
On 2012/09/30 18:19:15, yzshen1 wrote: > Thanks a lot for fixing this bug! > > ...
8 years, 2 months ago (2012-10-01 18:34:27 UTC) #4
yzshen1
LGTM Thanks! :)
8 years, 2 months ago (2012-10-01 19:17:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10986059/16001
8 years, 2 months ago (2012-10-01 19:24:22 UTC) #6
commit-bot: I haz the power
Presubmit check for 10986059-16001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-01 19:24:26 UTC) #7
Bernhard Bauer
Brett, could I have an OWNERS review?
8 years, 2 months ago (2012-10-01 19:33:31 UTC) #8
brettw
lgtm rubberstamp
8 years, 2 months ago (2012-10-01 19:35:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10986059/16001
8 years, 2 months ago (2012-10-01 19:38:28 UTC) #10
commit-bot: I haz the power
8 years, 2 months ago (2012-10-01 22:05:28 UTC) #11
Change committed as 159569

Powered by Google App Engine
This is Rietveld 408576698