Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 10986032: Add 'git clean -f -d' to 'gclient revert' when in a git repo. (Closed)

Created:
8 years, 2 months ago by lliabraa
Modified:
8 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Add 'git clean -f -d' to 'gclient revert' when in a git repo. The try slaves run 'git revert' to clean up from the previous run. This only runs 'git reset --hard', which does not remove any untracked files, so if a CL adds a new file it will still be present after 'gclient revert'. Adding git clean -f -d removes untracked files (-f) and directories (-d). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159020

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M gclient_scm.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/gclient_smoketest.py View 1 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lliabraa
8 years, 2 months ago (2012-09-25 20:07:13 UTC) #1
M-A Ruel
lgtm
8 years, 2 months ago (2012-09-25 20:10:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10986032/1
8 years, 2 months ago (2012-09-25 20:10:40 UTC) #3
commit-bot: I haz the power
Presubmit check for 10986032-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-09-25 20:13:14 UTC) #4
lliabraa
I've updated the test to reflect the addition of git clean. PTAL.
8 years, 2 months ago (2012-09-26 12:47:18 UTC) #5
M-A Ruel
lgtm, thanks
8 years, 2 months ago (2012-09-27 14:03:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10986032/6001
8 years, 2 months ago (2012-09-27 14:03:23 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-27 14:06:50 UTC) #8
Change committed as 159020

Powered by Google App Engine
This is Rietveld 408576698