Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 10986023: Fix nx crash. (Closed)

Created:
8 years, 2 months ago by rmsousa
Modified:
8 years, 2 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix nx crash. It's interesting that NX doesn't list the XTest devices. In any case, we should be fine just returning in this case (if there's no device there's no mapping that we need to fix). BUG=152079 TEST=it2me session on nx Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158704

Patch Set 1 #

Total comments: 1

Patch Set 2 : ERROR->INFO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M remoting/host/event_executor_linux.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmsousa
8 years, 2 months ago (2012-09-25 16:16:56 UTC) #1
Lambros
lgtm
8 years, 2 months ago (2012-09-25 16:52:46 UTC) #2
Jamie
http://codereview.chromium.org/10986023/diff/1/remoting/host/event_executor_linux.cc File remoting/host/event_executor_linux.cc (right): http://codereview.chromium.org/10986023/diff/1/remoting/host/event_executor_linux.cc#newcode306 remoting/host/event_executor_linux.cc:306: LOG(ERROR) << "Cannot find XTest device."; Nit: If we're ...
8 years, 2 months ago (2012-09-25 18:15:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmsousa@chromium.org/10986023/5001
8 years, 2 months ago (2012-09-25 21:54:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmsousa@chromium.org/10986023/5001
8 years, 2 months ago (2012-09-26 00:15:52 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 00:35:56 UTC) #6
Change committed as 158704

Powered by Google App Engine
This is Rietveld 408576698