Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 10986006: Fix return type of requestPriorityAtLastPriorityUpdate (Closed)

Created:
8 years, 2 months ago by ccameron
Modified:
8 years, 2 months ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Fix issue where CCprioritizedTexture::Backing's requestPriorityAtLastPriorityUpdate returns a bool instead of an int. This bug effectively disables the prioritized texture manager (so as soon as you hit memory pressure, we discard textures in more-or-less random order). This needs to be integrated to M23 as well. BUG=152050 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/CCPrioritizedTexture.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
ccameron
Big oops.
8 years, 2 months ago (2012-09-24 22:14:36 UTC) #1
ccameron
ptal
8 years, 2 months ago (2012-09-25 17:49:55 UTC) #2
danakj
lgtm, I think enne's out today.
8 years, 2 months ago (2012-09-25 18:37:08 UTC) #3
ccameron
On 2012/09/25 18:37:08, danakj wrote: > lgtm, I think enne's out today. Thanks!
8 years, 2 months ago (2012-09-25 19:26:47 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 2 months ago (2012-09-25 19:26:49 UTC) #5
ccameron
On 2012/09/25 19:26:49, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
8 years, 2 months ago (2012-09-25 19:31:37 UTC) #6
jamesr
lgtm
8 years, 2 months ago (2012-09-25 19:35:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/10986006/1
8 years, 2 months ago (2012-09-25 19:40:29 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-25 19:48:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/10986006/1
8 years, 2 months ago (2012-09-25 19:50:11 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-25 19:55:06 UTC) #11
ccameron
mac_rel is dying for reasons unrelated to this patch (GOMA: compiler proxy not working?). I'll ...
8 years, 2 months ago (2012-09-25 19:58:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/10986006/1
8 years, 2 months ago (2012-09-25 22:20:52 UTC) #13
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 23:58:35 UTC) #14
Change committed as 158698

Powered by Google App Engine
This is Rietveld 408576698