lib/html/src/dart2js_DOMImplementation.dart - Issue 10985089: Fix the type on a wrapped window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/src/dart2js_DOMImplementation.dart

Issue 10985089: Fix the type on a wrapped window (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Regen dart:html Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/html/src/dart2js_DOMImplementation.dart

diff --git a/lib/html/src/dart2js_DOMImplementation.dart b/lib/html/src/dart2js_DOMImplementation.dart

index 96d9a004f37a9453997c62c30005c0ae465e61a5..38da7b2143ce045eab9f639dde773af90b2cf122 100644

--- a/lib/html/src/dart2js_DOMImplementation.dart

+++ b/lib/html/src/dart2js_DOMImplementation.dart

@@ -4,8 +4,10 @@

// TODO(vsm): Unify with Dartium version.

class _DOMWindowCrossFrameImpl implements Window {

- // Private window.

- _WindowImpl _window;

+ // Private window. Note, this is a window in another frame, so it

+ // cannot be typed as "Window" as its prototype is not patched

+ // properly. Its fields and methods can only be accessed via JavaScript.

+ var _window;

// Fields.

// TODO(vsm): Implement history and location getters.

« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | tests/html/html.status » ('j') | no next file with comments »