Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 10985089: Fix the type on a wrapped window (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Regen dart:html Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/dart2js/html_dart2js.dart
diff --git a/lib/html/dart2js/html_dart2js.dart b/lib/html/dart2js/html_dart2js.dart
index 50334baa86f4f133d4fede4dbf763d635d1409e2..e2e9dc163799fbcbccc6eeec1537e83994f2bf51 100644
--- a/lib/html/dart2js/html_dart2js.dart
+++ b/lib/html/dart2js/html_dart2js.dart
@@ -40478,8 +40478,7 @@ class ReceivePortSync {
get _isolateId => ReceivePortSync._isolateId;
void _dispatchEvent(String receiver, var message) {
- var event = document.$dom_createEvent('CustomEvent');
- event.$dom_initCustomEvent(receiver, false, false, JSON.stringify(message));
+ var event = new CustomEvent(receiver, false, false, JSON.stringify(message));
window.$dom_dispatchEvent(event);
}
@@ -41412,8 +41411,10 @@ bool _isImmutableJavaScriptArray(value) =>
// TODO(vsm): Unify with Dartium version.
class _DOMWindowCrossFrameImpl implements Window {
- // Private window.
- _WindowImpl _window;
+ // Private window. Note, this is a window in another frame, so it
+ // cannot be typed as "Window" as its prototype is not patched
+ // properly. Its fields and methods can only be accessed via JavaScript.
+ var _window;
// Fields.
// TODO(vsm): Implement history and location getters.
« no previous file with comments | « no previous file | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698