Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc

Issue 10985069: [test fixlet] Add tests for the zoom icon in the location bar on GTK. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: making bubble tests interactive_ui_tests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc
diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc b/chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..192280794fce0eb239a8d2138b578e65275320e4
--- /dev/null
+++ b/chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc
@@ -0,0 +1,181 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <gtk/gtk.h>
+
+#include "base/string_number_conversions.h"
+#include "chrome/browser/ui/browser_commands.h"
+#include "chrome/browser/ui/browser_tabstrip.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/gtk/browser_toolbar_gtk.h"
+#include "chrome/browser/ui/gtk/browser_window_gtk.h"
+#include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "content/public/browser/notification_types.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
+#include "content/public/test/test_utils.h"
+
+#define ASSERT_ZOOM_EQ(contents, percent) \
Lei Zhang 2012/10/01 23:35:54 Any particular reason you prefer this over CheckZo
Dan Beam 2012/10/02 00:03:06 Not really, just seemed to be more familiar to the
Lei Zhang 2012/10/02 00:09:52 The C++ style guide prefers not to use them. http:
Dan Beam 2012/10/02 01:42:49 Done.
+ do { \
+ bool dummy; \
+ ASSERT_EQ(contents->GetZoomPercent(&dummy, &dummy), percent); \
+ } while (0)
+
+class LocationBarViewGtkZoomTest : public InProcessBrowserTest,
+ public BrowserWindowTesting {
+ public:
+ LocationBarViewGtkZoomTest() {
+ }
+
+ virtual ~LocationBarViewGtkZoomTest() {
+ }
+
+ content::WebContents* SetUpTest() {
+ content::WebContents* contents = chrome::GetActiveWebContents(browser());
+ ResetZoom();
+ return contents;
+ }
+
+ void ResetZoom() {
+ content::WindowedNotificationObserver zoom_observer(
+ content::NOTIFICATION_ZOOM_LEVEL_CHANGED,
+ content::NotificationService::AllSources());
+ chrome::Zoom(browser(), content::PAGE_ZOOM_RESET);
+ zoom_observer.Wait();
+ }
+
+ void ZoomIn() {
+ content::WindowedNotificationObserver zoom_observer(
+ content::NOTIFICATION_ZOOM_LEVEL_CHANGED,
+ content::NotificationService::AllSources());
+ chrome::Zoom(browser(), content::PAGE_ZOOM_IN);
+ zoom_observer.Wait();
+ }
+
+ void ZoomOut() {
+ content::WindowedNotificationObserver zoom_observer(
+ content::NOTIFICATION_ZOOM_LEVEL_CHANGED,
+ content::NotificationService::AllSources());
+ chrome::Zoom(browser(), content::PAGE_ZOOM_OUT);
+ zoom_observer.Wait();
+ }
+
+ void ExpectTooltipContains(int percent) {
+ gchar* text = gtk_widget_get_tooltip_text(GetZoomWidget());
+ std::string tooltip(text);
+ g_free(text);
+ EXPECT_TRUE(tooltip.find(base::IntToString(percent)) != std::string::npos);
+ }
+
+ BrowserWindowGtk* GetNativeBrowser() {
+ return static_cast<BrowserWindowGtk*>(browser()->window());
+ }
+
+ GtkWidget* GetZoomWidget() {
+ return GetNativeBrowser()->GetToolbar()->GetLocationBarView()->zoom_.get();
+ }
+
+ bool ZoomIconIsShowing() {
+ return gtk_widget_get_visible(GetZoomWidget());
+ }
+};
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedIn) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomIn();
+ ASSERT_ZOOM_EQ(contents, 110);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectTooltipContains(110);
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedInTwice) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomIn(); // 110%.
+ ZoomIn();
+ ASSERT_ZOOM_EQ(contents, 125);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectTooltipContains(125);
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedInAndBack) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomIn();
+ ASSERT_ZOOM_EQ(contents, 110);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectTooltipContains(110);
+
+ ZoomOut(); // Back to default, in theory.
+ ASSERT_ZOOM_EQ(contents, 100);
+ EXPECT_FALSE(ZoomIconIsShowing());
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, ZoomInTwiceAndReset) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomIn(); // 110%.
+ ZoomIn();
+ ASSERT_ZOOM_EQ(contents, 125);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectTooltipContains(125);
+
+ ResetZoom();
+ ASSERT_ZOOM_EQ(contents, 100);
+ EXPECT_FALSE(ZoomIconIsShowing());
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedOut) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomOut();
+ ASSERT_ZOOM_EQ(contents, 90);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectTooltipContains(90);
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedOutTwice) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomOut(); // 90%.
+ ZoomOut();
+ ASSERT_ZOOM_EQ(contents, 75);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectTooltipContains(75);
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedOutAndBack) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomOut();
+ ASSERT_ZOOM_EQ(contents, 90);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectTooltipContains(90);
+
+ ZoomIn(); // Back to default, in theory.
+ ASSERT_ZOOM_EQ(contents, 100);
+ EXPECT_FALSE(ZoomIconIsShowing());
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, ZoomOutTwiceAndReset) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomOut(); // 90%.
+ ZoomOut();
+ ASSERT_ZOOM_EQ(contents, 75);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectTooltipContains(75);
+
+ ResetZoom();
+ ASSERT_ZOOM_EQ(contents, 100);
+ EXPECT_FALSE(ZoomIconIsShowing());
+}
+
+#undef ASSERT_ZOOM_EQ

Powered by Google App Engine
This is Rietveld 408576698