Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3573)

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc

Issue 10985069: [test fixlet] Add tests for the zoom icon in the location bar on GTK. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: TODO() + comment fix Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc
diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc b/chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..447c01ff0159e48383ca0ba46688ffbcd52c2801
--- /dev/null
+++ b/chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc
@@ -0,0 +1,192 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <gtk/gtk.h>
+
+#include "base/string_number_conversions.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_commands.h"
+#include "chrome/browser/ui/browser_tabstrip.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/gtk/browser_toolbar_gtk.h"
+#include "chrome/browser/ui/gtk/browser_window_gtk.h"
+#include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
+#include "chrome/browser/ui/zoom/zoom_controller.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_types.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/common/page_zoom.h"
+#include "grit/theme_resources.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class LocationBarViewGtkZoomTest : public InProcessBrowserTest {
+ public:
+ LocationBarViewGtkZoomTest() {
+ }
+
+ virtual ~LocationBarViewGtkZoomTest() {
+ }
+
+ protected:
+ void ExpectTooltipContains(int percent) {
+ gchar* text = gtk_widget_get_tooltip_text(GetZoomWidget());
+ std::string tooltip(text);
+ g_free(text);
+ EXPECT_TRUE(tooltip.find(base::IntToString(percent)) != std::string::npos);
+ }
+
+ bool ZoomIconIsShowing() {
+ return gtk_widget_get_visible(GetZoomWidget());
+ }
+
+ void ExpectIconIsResource(int resource_id) {
+ // TODO(dbeam): actually compare the image bits with gfx::test::IsEqual?
+ content::WebContents* contents = chrome::GetActiveWebContents(browser());
+ ZoomController* zoom_controller = ZoomController::FromWebContents(contents);
+ EXPECT_EQ(resource_id, zoom_controller->GetResourceForZoomLevel());
+ }
+
+ // TODO(dbeam): share below code with ZoomBubbleGtkTest.
+ void AssertZoomEquals(content::WebContents* contents, int percent) {
+ bool dummy; // Knowing whether we can zoom in or out more isn't required.
+ ASSERT_EQ(percent, contents->GetZoomPercent(&dummy, &dummy));
+ }
+
+ void ResetZoom() {
+ WaitForZoom(content::PAGE_ZOOM_RESET);
+ }
+
+ content::WebContents* SetUpTest() {
+ content::WebContents* contents = chrome::GetActiveWebContents(browser());
+ ResetZoom();
+ AssertZoomEquals(contents, 100);
+ return contents;
+ }
+
+ void ZoomIn() {
+ WaitForZoom(content::PAGE_ZOOM_IN);
+ }
+
+ void ZoomOut() {
+ WaitForZoom(content::PAGE_ZOOM_OUT);
+ }
+
+ private:
+ GtkWidget* GetZoomWidget() {
+ return static_cast<BrowserWindowGtk*>(browser()->window())->GetToolbar()->
+ GetLocationBarView()->zoom_.get();
Evan Stade 2012/10/02 08:12:00 another place to use ViewIDs
Dan Beam 2012/10/02 16:41:42 Done.
+ }
+
+ void WaitForZoom(content::PageZoom zoom_action) {
+ content::WindowedNotificationObserver zoom_observer(
+ content::NOTIFICATION_ZOOM_LEVEL_CHANGED,
+ content::NotificationService::AllSources());
+ chrome::Zoom(browser(), zoom_action);
+ zoom_observer.Wait();
+ }
+
+ DISALLOW_COPY_AND_ASSIGN(LocationBarViewGtkZoomTest);
+};
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedIn) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomIn();
+ AssertZoomEquals(contents, 110);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectIconIsResource(IDR_ZOOM_PLUS);
+ ExpectTooltipContains(110);
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedInTwice) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomIn(); // 110%.
+ ZoomIn();
+ AssertZoomEquals(contents, 125);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectIconIsResource(IDR_ZOOM_PLUS);
+ ExpectTooltipContains(125);
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedInAndBack) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomIn();
+ AssertZoomEquals(contents, 110);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectIconIsResource(IDR_ZOOM_PLUS);
+ ExpectTooltipContains(110);
+
+ ZoomOut(); // Back to default, in theory.
+ AssertZoomEquals(contents, 100);
+ EXPECT_FALSE(ZoomIconIsShowing());
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, ZoomInTwiceAndReset) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomIn(); // 110%.
+ ZoomIn();
+ AssertZoomEquals(contents, 125);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectIconIsResource(IDR_ZOOM_PLUS);
+ ExpectTooltipContains(125);
+
+ ResetZoom();
+ AssertZoomEquals(contents, 100);
+ EXPECT_FALSE(ZoomIconIsShowing());
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedOut) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomOut();
+ AssertZoomEquals(contents, 90);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectIconIsResource(IDR_ZOOM_MINUS);
+ ExpectTooltipContains(90);
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedOutTwice) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomOut(); // 90%.
+ ZoomOut();
+ AssertZoomEquals(contents, 75);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectIconIsResource(IDR_ZOOM_MINUS);
+ ExpectTooltipContains(75);
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, DefaultToZoomedOutAndBack) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomOut();
+ AssertZoomEquals(contents, 90);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectIconIsResource(IDR_ZOOM_MINUS);
+ ExpectTooltipContains(90);
+
+ ZoomIn(); // Back to default, in theory.
+ AssertZoomEquals(contents, 100);
+ EXPECT_FALSE(ZoomIconIsShowing());
+}
+
+IN_PROC_BROWSER_TEST_F(LocationBarViewGtkZoomTest, ZoomOutTwiceAndReset) {
+ content::WebContents* contents = SetUpTest();
+
+ ZoomOut(); // 90%.
+ ZoomOut();
+ AssertZoomEquals(contents, 75);
+ EXPECT_TRUE(ZoomIconIsShowing());
+ ExpectIconIsResource(IDR_ZOOM_MINUS);
+ ExpectTooltipContains(75);
+
+ ResetZoom();
+ AssertZoomEquals(contents, 100);
+ EXPECT_FALSE(ZoomIconIsShowing());
+}

Powered by Google App Engine
This is Rietveld 408576698